Fix treemacs-tag-follow-mode in gfm-mode#1174
Open
knu wants to merge 1 commit intoAlexander-Miller:masterfrom
Open
Fix treemacs-tag-follow-mode in gfm-mode#1174knu wants to merge 1 commit intoAlexander-Miller:masterfrom
knu wants to merge 1 commit intoAlexander-Miller:masterfrom
Conversation
Alexander-Miller
requested changes
Dec 26, 2025
| ;; is still stored as a text property | ||
| (semantic? (and (consp first) (overlayp (cdr first)))) | ||
| (compare-func (if (memq major-mode '(markdown-mode adoc-mode)) | ||
| (compare-func (if (derived-mode-p 'markdown-mode 'adoc-mode) |
Owner
There was a problem hiding this comment.
The signature is (derived-mode-p MODES &rest DEPRECATED-ARGS) so the mods should stay in a list.
In gfm-mode, which is a derived mode from markdown-mode, treemacs-tag-follow-mode fails with the following error message. ``` [Treemacs] Encountered error while following tag at point: (wrong-type-argument markerp 150) ``` The problem is in treemacs--flatten&sort-imenu-index that chooses a compare function not suitable for the mode.
|
This issue has been automatically marked as stale because it has not had recent activity (this bot only works as a reminder, it will not close issues). |
Author
|
This is a one-line fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In gfm-mode, which is a derived mode from markdown-mode, treemacs-tag-follow-mode fails with the following error message.
The problem is in treemacs--flatten&sort-imenu-index that chooses a compare function not suitable for the mode.