[Git] Fix loss of environment propagation in Python scripts.#1173
Merged
Alexander-Miller merged 1 commit intoAlexander-Miller:masterfrom Dec 26, 2025
Merged
Conversation
jmsgrogan
commented
Dec 22, 2025
| if mu_dir == "/": | ||
| continue | ||
|
|
||
| environ["LC_ALL"] = "C" |
Author
There was a problem hiding this comment.
Note this approach environ["FOO"] = "BAR" was previously taken in one of the scripts before the most recent change - so there is some precedent for it.
Owner
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in this issue: #1172 git calls have started failing on systems like NixOs and Guix.
This started with this commit: 2dd6d86
The commit explicitly set the subprocess environment just to have the value:
"LC_ALL": "C". This prevents systems like NixOs and Guix from passing shell environment variables to allow 'git' to be found in their stores.The fix is to append
"LC_ALL": "C"to the environment, rather than recreating a new env.I did a basic test after to confirm that Emacs now launches with Treemacs by dropping in the modified scripts.