Fix treemacs-git-commit-diff-mode when a non-English locale is set#1155
Merged
Alexander-Miller merged 1 commit intoAlexander-Miller:masterfrom Sep 7, 2025
Merged
Fix treemacs-git-commit-diff-mode when a non-English locale is set#1155Alexander-Miller merged 1 commit intoAlexander-Miller:masterfrom
treemacs-git-commit-diff-mode when a non-English locale is set#1155Alexander-Miller merged 1 commit intoAlexander-Miller:masterfrom
Conversation
Contributor
Author
|
Hello @Alexander-Miller! I was wondering if you had any chance to have a look at this fix? |
0e2641d to
daf6f66
Compare
Owner
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some features like
treemacs-git-commit-diff-modeare broken when a non-English locale is set.This is due to the parsing logic contained in the Python scripts which expect
gitcommands output to be in English.Ex.:
treemacs-git-commit-diff.pyandtreemacs-find-ignored-files.pyare two examples of scripts that are not working properly when a non-English locale is set.gitcommands executed with--procelainshouldn’t be affected by this issue. But for consistency, I decided to explicitly reset the locale for all the commands run by all the Python scripts.(*) “devant” is the french translation of “ahead” and “Supprimerait” is the french translation of “Would remove”.