Simplify unallocation to sync-only flow #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move syncRedeem from requestUnallocate to completeUnallocate, eliminating async flow and proportional distribution. Each user now gets exactly their pending amount via direct syncRedeem call during completion. - Remove async flow logic and proportional distribution - Add rescueTokens function for owner to recover surplus tokens - Update tests to reflect new sync-only behavior - Remove obsolete skip_test_ functions that tested old async flow - Reduce bytecode by ~700 bytes (now 23,750 bytes with 826 margin)
0xtechdean
force-pushed
the
sync-unallocate-flow
branch
from
cc20da7 to
2c24ef0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
syncRedeemfromrequestUnallocatetocompleteUnallocate, eliminating async flow and proportional distributionsyncRedeemcall during completionrescueTokensfunction for owner to recover surplus tokens from the contractChanges
rescueTokensfunctionBytecode
Test plan
forge fmtapplied