Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 7, 2026

Corrects three typos in the warning message displayed when the away team's position validation fails in check_inputs_game_object().

Changes:

  • Fixed "playingfrom" → "playing from"
  • Fixed "At the start of period" → "At the start of period" (removed double space)
  • Fixed "centroid ofthe" → "centroid of the"

The corrected message now reads:

"The away team should be represented as playing from right to "
f"left the whole game. At the start of period {period} the x "
f"centroid of the away team is {centroid_x}."

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: Alek050 <49450063+Alek050@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback from review on kloppy skillcorner fix PR Fix spelling errors in away team validation warning message Jan 7, 2026
Copilot AI requested a review from Alek050 January 7, 2026 12:19
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.55%. Comparing base (d4e2dc2) to head (57c745a).
⚠️ Report is 1 commits behind head on 332-kloppy-skillcorner-error.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           332-kloppy-skillcorner-error     #336   +/-   ##
=============================================================
  Coverage                         99.55%   99.55%           
=============================================================
  Files                                65       65           
  Lines                              4973     4973           
=============================================================
  Hits                               4951     4951           
  Misses                               22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Alek050 Alek050 marked this pull request as ready for review January 7, 2026 12:44
@Alek050 Alek050 merged commit 88833d9 into 332-kloppy-skillcorner-error Jan 7, 2026
14 checks passed
@Alek050 Alek050 deleted the copilot/sub-pr-335 branch January 7, 2026 12:44
Alek050 added a commit that referenced this pull request Jan 7, 2026
* from kloppy skillcorner fix

* Update databallpy/utils/get_game.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix spelling errors in away team validation warning message (#336)

* Initial plan

* Fix spelling errors in warning message for away team validation

Co-authored-by: Alek050 <49450063+Alek050@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Alek050 <49450063+Alek050@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants