feat!: fully to transition to observability and reactivity #5084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring callback invocation
…l callback Now the "laziness" concept is applied to dervied observables too.
For actions in general, it is better to use an imperative approach and retrieve the current neighborhood instead of having an up-to-date neighborhood version stored locally.
…ency graph fix: remove obsolete reactive engine loading chore(engine): use explicit synchronisation instead of thread contexts
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/reactive-engine #5084 +/- ##
=======================================================
Coverage 61.53% 61.53%
Complexity 14 14
=======================================================
Files 2 2
Lines 78 78
Branches 4 4
=======================================================
Hits 48 48
Misses 24 24
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes the
Enginehas been replaced by its reactive counterpart and theBatchEngineis then refactored to support such change. As a result of this,DependencyGraphis no more needed.Finally, all core operations on positions, neighbourhoods and nodes contents have transitioned to their reactive counterparts, or are being backed by the reactive alternative method: the motivation behind this choice is for reducing the proliferation of calling
currentorgetCurrent()on observables when the user is modelling a "proactive" behaviour.