Consolidate Console Layout Events and Fix Batch Queue State Leaks#287
Merged
github-actions[bot] merged 1 commit intoNightlyfrom Mar 23, 2026
Merged
Conversation
…state leaks ### Generated by: .github/prompts/optimization.md ### Reasoning: **[Bottleneck Identified]:** Structural rot in the view layer where `RosterView` and `HeadhunterView` manually bound nearly a dozen events from the controller to `ConsoleLayout`, leading to high boilerplate and maintenance friction. Additionally, a state leak existed in `useBatchQueue` where the `currentIndex` was not reset during selection clears. **[Refactoring Hypothesis]:** Centralizing event-to-handler mapping in a `layoutEvents` computed property within `useConsoleController` allows for bulk binding in the view layer (`v-on="layoutEvents"`). This improves structural purity and ensures consistent event handling across features. **[Rationale]:** Aligns with the "Clean Stack" and Structural Unitary Architecture by hoisting orchestration logic into Layer 1 services and reducing feature-layer boilerplate. ### Changes: - **[Frontend-PWA/src/core/services/useConsoleController.ts]:** Introduced `layoutEvents` computed property for bulk event binding and added `onDismiss` configuration option. - **[Frontend-PWA/src/features/roster/views/RosterView.vue]:** Refactored to use `v-on="layoutEvents"`, reducing template complexity. - **[Frontend-PWA/src/features/headhunter/views/HeadhunterView.vue]:** Refactored to use `v-on="layoutEvents"` and removed unused local variables. - **[Frontend-PWA/src/features/headhunter/composables/useRecruiter.ts]:** Updated to inject `dismissBulk` into the controller's `onDismiss` handler. - **[Frontend-PWA/src/core/services/useBatchQueue.ts]:** Hardened `clearSelection` to ensure `currentIndex` is reset, preventing state leakage between batch operations. ### Verification: - **[Automated]:** All 633 tests in `Frontend-PWA` passed, including `useConsoleController.spec.ts` and `useLeaderboard.spec.ts`. - **[Manual/Audit]:** Verified template logic reduction in view files and confirmed zero-regression in event firing via architectural audit. ### Log Updates: - Updated .github/nightly-logs/optimization-coverage.log
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
bot
deleted the
nightly-optimize-console-events-8781379368693276991
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated console layout events into a single
layoutEventsobject inuseConsoleController.ts, allowing for bulk event binding inRosterViewandHeadhunterView. This refactor reduces structural rot and boilerplate in the view layer while maintaining the feature-specific behavior for dismiss actions. Additionally, hardened theuseBatchQueueservice by ensuring thecurrentIndexis reset when the selection is cleared, fixing a potential state leak during multi-mode operations.PR created automatically by Jules for task 8781379368693276991 started by @AlbiDR