-
Notifications
You must be signed in to change notification settings - Fork 74
Some features and improvements #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DV666
wants to merge
14
commits into
Albeoris:main
Choose a base branch
from
DV666:FeaturesAndImprovements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Awesome stuff! Thanks for looking into the DictionaryParch when you have
time(:
…On Wed, Jul 30, 2025 at 4:23 PM DV666 ***@***.***> wrote:
I made this PR for many little ideas i want to make... i note them here
and i will work on it when i get time.
✅ New hack for AllCharactersAvailable (option 2) : keep the default name
for the characters.
⚙️Need to improve the SwapFieldModelTexture feature : precise the actorId
to be more precise... (or maybe NCalc ?)
⚙️Need a NCalc to check if a player has a SA or not (different to HasSA)
⚙️Feature to hide SaHidden in player's menu (need an option in Memoria ?
new parameter for SaHidden ?)
⚙️Need a new feature in DictionnaryPatch.txt to add specific parameters
for custom model (#1252 <#1252>)
Tirlititi suggests this format => 3DModelParameter MODELID HEIGHT RADIUS
BONENECK
⚙️Memoria supports folder instead of an .ogg file for music : meaning you
can put a kind of "playlist" for a specific ID.
------------------------------
You can view, comment on, or merge this pull request online at:
#1255
Commit Summary
- 1200c94
<1200c94>
DisableNameChoice new hack : keep default name
File Changes
(4 files <https://github.com/Albeoris/Memoria/pull/1255/files>)
- *M* Assembly-CSharp/Global/Event/Engine/EventEngine.DoEventCode.cs
<https://github.com/Albeoris/Memoria/pull/1255/files#diff-d0e91c3603859252aeda1446492eaa9a9e519e6e4e6aab022023e2e1d57b39e4>
(2)
- *M* Assembly-CSharp/Global/PLAYER.cs
<https://github.com/Albeoris/Memoria/pull/1255/files#diff-6eb1795531529938c557c04334e5173cfcf1ae1332d20710f5bae51b5f2b941e>
(3)
- *M* Assembly-CSharp/Memoria/Configuration/Access/Hacks.cs
<https://github.com/Albeoris/Memoria/pull/1255/files#diff-6c0353bcd3ed8ac631eb35ed48dc61eab21f4c7db944098eb58aa81cd27381e0>
(2)
- *M* Assembly-CSharp/Memoria/Configuration/Structure/HacksSection.cs
<https://github.com/Albeoris/Memoria/pull/1255/files#diff-4745c7594cba13d9ee35a8df64bc0e8c7bd17081ff13899b41335ae11261d792>
(4)
Patch Links:
- https://github.com/Albeoris/Memoria/pull/1255.patch
- https://github.com/Albeoris/Memoria/pull/1255.diff
—
Reply to this email directly, view it on GitHub
<#1255>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVQGRMXTUSAND2I7X2HCRAL3LESSVAVCNFSM6AAAAACCX7ELJWVHI2DSMVQWIX3LMV43ASLTON2WKOZTGI3TQMZUG4ZTQMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
13c783a to
40dbbae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this PR for many little ideas i want to make... i note them here and i will work on it when i get time.
✅ New hack for
AllCharactersAvailable(option 2) : keep the default name for the characters.⚙️Need to improve the
SwapFieldModelTexturefeature : precise the actorId to be more precise... (or maybe NCalc ?)✅Need a new NCalc to check if a player has a SA or not (different to
HasSA).... ?⚙️Need to improve some btl_scrp functions for my NPC debug => Will be useful later for a kind of "Debug room project".
Editing a variable, give all items, learns all SA on a characters, etc...
⚙️Feature to hide
SaHiddenin player's menu (need an option in Memoria ? new parameter for SaHidden ?)✅Need a new feature in
DictionnaryPatch.txtto add specific parameters for custom model (#1252)Tirlititi suggests this format =>
3DModelParameter MODELID HEIGHT RADIUS BONENECKSource : https://github.com/Albeoris/Memoria/blob/main/Assembly-CSharp/Global/ff9/Battle/FF9BattleDBHeightAndRadius.cs
❌Memoria supports folder instead of an .ogg file for music : meaning you can put a kind of "playlist" for a specific ID. (edit : i will that later... don't have enough time).
✅Add a new parameter for Libra => Show stats on the target and loot earned.
✅
BanishSAshow the SA, even if the player hasn't teach the SA on the character.⚙️When altering HP or MP via SA with a piece of equipment, the player can't loose HP/MP, even if he didn't equip it.
✅Need to replace btl_abil.CheckCoverAbility position for monsters, when using Cover :
target.pos[2] += target.bi.player != 0 ? -400f : 400f;✅ Need to create a
HardDisableargument for AA (AbilityFeatures.txt)⚙️ Remove the hardcoded limit for
EffectElementandEnemyCategory❓ Idea for Sitri, a way to order manually AA and SA in game (in the menu player)
✅ Added a small safety feature to disable a player's SAs when loading a save, if they no longer have them in his .csv