.NET Framework and Core Sample Bug Fixes#12
Open
HassaanYounas wants to merge 35 commits intomasterfrom
Open
Conversation
…cconf missing error.
…f and config.ncconf missing error.
…des updated PowerShell script.
…o fix .ncconf missing files.
…ache-Samples into net-framework-core
…amework and Core.
…se samples are already present in DataStructures samples.
…ache-Samples into net-framework-core
…ache-Samples into net-framework-core
…e" to "demoCache".
…ache-Samples into net-framework-core
…ache-Samples into net-framework-core
danyialkhan
suggested changes
Sep 2, 2021
Comment on lines
-16
to
-21
| <None Update="client.ncconf"> | ||
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | ||
| </None> | ||
| <None Update="config.ncconf"> | ||
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | ||
| </None> |
Contributor
There was a problem hiding this comment.
Why these references are removed?
Author
There was a problem hiding this comment.
Because if we install the SDK in a Solution containing multiple projects, the config files are only copied to one project and thus only that project has the references in its csproj file.
Comment on lines
-124
to
-126
| <None Include="tls.ncconf"> | ||
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | ||
| </None> |
Contributor
There was a problem hiding this comment.
why client.ncconf and config.ncconf are present here?
Author
There was a problem hiding this comment.
Because these config files are required by the SDK and their reference is added upon installation of SDK package.
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Alachisoft.NCache.EFCore" Version="5.0.2.*" /> | ||
| <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="2.2.1" /> |
Contributor
There was a problem hiding this comment.
why removed this refernece
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.