Feat/multiplication by OphelieThomas33 · Pull Request #2 · AlaAtrash/calculator

OphelieThomas33 · 2023-01-20T19:38:07Z

No description provided.

ABBA-74 · 2023-01-20T19:53:38Z

.vscode/settings.json

 {
-  "liveServer.settings.port": 5501
+  "liveServer.settings.port": 5502
 }


add to .gitignore ?

ok it's done

AlaAtrash · 2023-01-20T19:45:51Z

.vscode/settings.json

@@ -1,3 +1,3 @@
 {
-  "liveServer.settings.port": 5501


add to .gitignore

AlaAtrash · 2023-01-20T19:46:52Z

README.md

 ### Langage et Package

 - TypeScript
+- Nodejs


the rebase didn't work for this file, so I copied the main

AlaAtrash · 2023-01-20T19:49:29Z

README.md

 $ "files": ["src/index.ts", "src/sin_cos.ts"]
 ```
+
+## Tester son fichier JS


same here !

the rebase didn't work for this file, so I copied the main

AlaAtrash · 2023-01-20T19:51:56Z

dist/multiplication.js

+let affichageResultat = document.querySelector('#resultat');
+let resultat;
+
+function multiplication(a, b) {


you can use arrow function instead
const multiplication = (a,b) => {

}

ok I changed

AlaAtrash · 2023-01-20T19:56:50Z

dist/multiplication.js

@@ -0,0 +1,23 @@
+"use strict";


add dist to .gitignore

AlaAtrash · 2023-01-20T20:02:08Z

index.html

+    <button class="button-multiplication">Multiplier</button>
+    <p id="resultat"></p>
+
    <script type="module" src="dist/index.js"></script>


<script type="module" src="index.js"></script>

AlaAtrash · 2023-01-20T20:11:27Z

src/multiplication.ts

@@ -0,0 +1,30 @@
+let inputA = document.querySelector('#numberA') as HTMLInputElement;


test document.getElementbyId()

AlaAtrash · 2023-01-20T20:12:15Z

src/multiplication.ts

+let resultat: number
+
+
+function multiplication(a: number, b: number) {


prefer arrow function
const multiplication= (a: number, b: number) => {
}

AlaAtrash · 2023-01-20T20:14:31Z

src/multiplication.ts

+
+function multiplication(a: number, b: number) {
+
+	if (a == null || b == null || isNaN(a) || isNaN(b)) {


AlaAtrash · 2023-01-20T20:15:49Z

tsconfig.json

    "strict": true
  },
-  "files": ["src/index.ts"]
+  "files": ["src/index.ts", "src/multiplication.ts"]


we can generalise ["src/*.ts]

ok I changed

AlaAtrash · 2023-01-20T20:19:30Z

to do

…l/css files to dist

…ion - change querySelector to getElementById

…ow function - change querySelector to getElementById" This reverts commit 9145e68.

…l/css files to dist

…o feat/homePageV2

Temp/main

…ion - change querySelector to getElementById

…ow function - change querySelector to getElementById" This reverts commit 9145e68.

…ion - change querySelector to getElementById

…ow function - change querySelector to getElementById" This reverts commit 9145e68.

… into feat/multiplication

OphelieThomas33 and others added 10 commits January 15, 2023 11:59

Init files

bfc9d97

add input and button

c87a359

test ts file

f1b8e42

feat/add branch created

83bd390

modify multiplication.ts

9d5b25f

rebase

dc28b86

add input and button

ed1e057

rebase

4254b89

rebase

edb9ef5

Fix function

5a3a2ce

ABBA-74 reviewed Jan 20, 2023

View reviewed changes

ABBA-74 closed this Jan 20, 2023

AlaAtrash requested changes Jan 20, 2023

View reviewed changes

AlaAtrash reopened this Jan 20, 2023

seb76370 and others added 15 commits January 20, 2023 22:40

add script to compile ==> npm run build, compile ts file and copy htm…

c3a316f

…l/css files to dist

remove directory test

dc87164

creat html & css calculator

db17fea

first commit

173202e

fix: issue on npm run build / remove all dist > build

6e0c756

update index.js to build project

87eb877

opt: added dataset for all calculator keys

20a29ff

opt: animtion btns on hover

16769c5

html: added title h1

7c86be5

Add vscode and dist in gitignore

2e60537

add vscode and dist in gitignore

6c6271e

add index.html and style.css in dist - change function to arrow funct…

9145e68

…ion - change querySelector to getElementById

Revert "add index.html and style.css in dist - change function to arr…

176f9a0

…ow function - change querySelector to getElementById" This reverts commit 9145e68.

name of variables in english

6ecf0d7

test ts file

26a920a

seb76370 and others added 30 commits January 27, 2023 20:32

add script to compile ==> npm run build, compile ts file and copy htm…

4beae0d

…l/css files to dist

remove directory test

3ef57e3

creat html & css calculator

1bb50f4

first commit

1758bd8

fix: issue on npm run build / remove all dist > build

ff0af33

opt: added dataset for all calculator keys

113ed95

opt: animtion btns on hover

2264446

html: added title h1

7708b99

Merge branch 'feat/homePageV2' of github.com:AlaAtrash/calculator int…

44db12e

…o feat/homePageV2

Merge branch 'feat/homePageV2' into Temp/main

501471f

Merge pull request #5 from AlaAtrash/Temp/main

73305a4

Temp/main

rebase

955fa76

add input and button

245be99

rebase

d281a93

test ts file

ff8e39c

modify multiplication.ts

59d0cff

Fix function

7a157d1

Add vscode and dist in gitignore

d3ca44e

add vscode and dist in gitignore

444e0fa

add index.html and style.css in dist - change function to arrow funct…

1598d47

…ion - change querySelector to getElementById

Revert "add index.html and style.css in dist - change function to arr…

a6a926e

…ow function - change querySelector to getElementById" This reverts commit 9145e68.

name of variables in english

e5b2f7a

Init files

5ba5eb4

add input and button

ad2d75d

modify multiplication.ts

ecf7240

add index.html and style.css in dist - change function to arrow funct…

cb199b2

…ion - change querySelector to getElementById

Revert "add index.html and style.css in dist - change function to arr…

9077fa7

…ow function - change querySelector to getElementById" This reverts commit 9145e68.

multiplication of decimals

4fe3493

add validation function and multiplication if more than 2 decimals

d570c3b

Merge branch 'feat/multiplication' of github.com:AlaAtrash/calculator…

cd9f168

… into feat/multiplication

		@@ -0,0 +1,30 @@
		let inputA = document.querySelector('#numberA') as HTMLInputElement;

		let resultat: number


		function multiplication(a: number, b: number) {


		function multiplication(a: number, b: number) {

		if (a == null \|\| b == null \|\| isNaN(a) \|\| isNaN(b)) {

Conversation

OphelieThomas33 commented Jan 20, 2023

Uh oh!

ABBA-74 Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlaAtrash commented Jan 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ABBA-74 Jan 20, 2023 •

edited

Loading