Skip to content

Remove redundant arg from ServiceManager's impl #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Currypan1229 merged 1 commit into from
Jan 31, 2026
Merged

Remove redundant arg from ServiceManager's impl #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions service/src/main/java/org/akazukin/service/manager/multi/MultiServiceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,20 +26,16 @@
@FieldDefaults(level = AccessLevel.PROTECTED, makeFinal = true)
@ThreadSafe
public class MultiServiceManager<U> extends ServiceManager<U> implements IMultiServiceManager<U> {
Class<U> serviceType;
@Getter
IServiceRegistry<U> registry;

/**
* Constructs an instance of ASingleServiceManager with the specified service type.
*
* @param serviceType The class object representing the type of the service.
* Must not be {@code null}.
* @param registry The service registry to be used by this manager.
* Must not be {@code null}.
* @param registry The service registry to be used by this manager.
* Must not be {@code null}.
*/
public MultiServiceManager(@NotNull final Class<U> serviceType, @NotNull final IServiceRegistry<U> registry) {
this.serviceType = serviceType;
public MultiServiceManager(@NotNull final IServiceRegistry<U> registry) {
this.registry = registry;
}

Expand Down
10 changes: 3 additions & 7 deletions service/src/main/java/org/akazukin/service/manager/single/SingleServiceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,16 @@
@FieldDefaults(level = AccessLevel.PROTECTED, makeFinal = true)
@ThreadSafe
public class SingleServiceManager<U> extends ServiceManager<U> implements ISingleServiceManager<U> {
Class<U> serviceType;
@Getter
IServiceRegistry<U> registry;

/**
* Constructs an instance of ASingleServiceManager with the specified service type.
*
* @param serviceType The class object representing the type of the service.
* Must not be {@code null}.
* @param registry The service registry to be used by this manager.
* Must not be {@code null}.
* @param registry The service registry to be used by this manager.
* Must not be {@code null}.
*/
public SingleServiceManager(@NotNull final Class<U> serviceType, @NotNull final IServiceRegistry<U> registry) {
this.serviceType = serviceType;
public SingleServiceManager(@NotNull final IServiceRegistry<U> registry) {
this.registry = registry;
}

Expand Down
Loading