-
Notifications
You must be signed in to change notification settings - Fork 0
feat(kiosk): hotspot and mobile data toggles #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b7c009f
feat(kiosk): hotspot and mobile data toggles
AkarinServer 444d288
feat(kiosk): request location and show hotspot credentials
AkarinServer 352ac3e
fix(kiosk): report hotspot failure reasons
AkarinServer d3ee314
fix(kiosk): detect system hotspot already enabled
AkarinServer a489024
feat(kiosk): refresh network status and show system hotspot info
AkarinServer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Android 6+
startLocalOnlyHotspot()requires the ACCESS_FINE_LOCATION runtime permission (and location services on), but this path doesn’t check/request it before calling the API. On a fresh install where the user hasn’t granted location permission in app settings, this throws/returns failure and the UI fallback only opens tether settings, which won’t grant the app permission. Result: the hotspot toggle will consistently fail until the user manually grants location permission in the app settings.Useful? React with 👍 / 👎.