kafka: add support for SASL authentication #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for SASL (Simple Authentication and Security Layer) authentication to the Kafka sender in journalpump, enabling authentication with Kafka clusters that require SASL credentials.
Changes:
- Added support for explicit
security_protocolconfiguration with SASL_PLAINTEXT and SASL_SSL options - Added SASL authentication configuration parameters (mechanism, username, password)
- Updated SSL configuration to work with both SSL and SASL_SSL protocols
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| journalpump/senders/kafka_sender.py | Refactored security protocol configuration to support SASL authentication methods and added SASL credential configuration |
| README.rst | Added documentation for the new security_protocol, sasl_mechanism, sasl_plain_username, and sasl_plain_password configuration parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tvainika
force-pushed
the
kafka-sender-sasl-auth
branch
from
1cb0b2f to
4e0a1e6
Compare
tvainika
force-pushed
the
kafka-sender-sasl-auth
branch
from
4e0a1e6 to
0f3a7c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.