fix: use milliseconds when calculating polling frequency #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiven-marko-rauhamaa
approved these changes
Oct 30, 2025
nanoseconds were being used in conjuction with milliseconds. Clarify the units in the variable name, and use `time.monotonic()` which returns fractional seconds already. Previously, when calculating the polling timeout, the incorrect use of units would result in `0`. This would make the `poll()` function return instantly, rather than efficiently waiting until the next event for up to a second. This change should therefore decrease CPU consumption and slightly decrease latency before new events are detected and processed.
nicois
force-pushed
the
nicois/fix-journalpump-polling-interval
branch
from
73d75b4 to
351e848
Compare
nicois
changed the title
allhailwesttexas
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nanoseconds were being used in conjuction with milliseconds. Clarify the units in the variable name, and use
time.monotonic()which returns fractional seconds already.Previously, when calculating the polling timeout, the incorrect use of units would result in
0. This would make thepoll()function return instantly, rather than efficiently waiting until the next event for up to a second.This change should therefore decrease CPU consumption and slightly decrease latency before new events are detected and processed.