Add PR description update support to git_push_to_branch #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional pr_description parameter to git_push_to_branch - Slash command now gathers current PR info via gh pr view - Tool updates PR description if provided and PR exists - Updates config, handler, and executor function signatures
Added guidance for creating detailed commit messages when addressing PR feedback. Changes: - Added "PR Feedback Response" section to .claude/commands/git_push.md (lines 19-48) - Instructs to use structured format in commit message body: ✅ Addressed items with file:line references ⏭️ Deferred items with rationale ❌ Not applicable items with clear reasoning - Includes example commit message format - Ensures feedback responses are documented in git history, not just PR descriptions This improves PR review workflows by standardizing how feedback is documented in commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced the
git_push_to_branchtool to support updating PR descriptions when pushing changes to branches with existing pull requests.Changes
Initial Implementation
Slash Command (
.claude/commands/git_push.md)gh pr viewto context gathering to fetch current PR infopr_descriptionparameter documentationConfiguration (
src/config.yaml)pr_descriptionparameter togit_push_to_branchtool definitionImplementation (
src/mcp_server.py)execute_git_push_to_branch()to accept optionalpr_descriptionparametergh pr editif description providedpr_descriptionPR Feedback Fixes
Fail-Fast Enforcement (
src/mcp_server.py:316)pr_descriptionRobust PR Body Handling (
src/mcp_server.py:312-328)--bodyto--body-filefor PR description updatesEmpty Files List Validation (
src/mcp_server.py:287,216,360)Documentation Fix (
.claude/commands/git_push.md:28-29)pr_descriptionto "Optional parameters" sectionBehavior
pr_descriptionis provided and a PR exists for the branch, the PR description is updated via temp filepr_descriptionprovided, behaves exactly as before (no change)Design Philosophy
Simple KISS implementation with proper error handling - no fallbacks or partial success masking. Follows fail-fast principle consistently.