RAV-2958 - Initial Proxy Protocol processing #1

bplessis-swi · 2025-10-27T14:34:47Z

Implementation of ProxyProtocol protocol decoding.

:

cthirouin-swi

Overall it's okay.

README.md

proxy-socket-core/src/main/java/net/airvantage/proxysocket/core/ProxyAddressCache.java

...-socket-core/src/main/java/net/airvantage/proxysocket/core/ProxyProtocolMetricsListener.java

...y-socket-core/src/main/java/net/airvantage/proxysocket/core/cache/NoOpProxyAddressCache.java

proxy-socket-core/src/main/java/net/airvantage/proxysocket/core/v2/ProxyProtocolV2Decoder.java

proxy-socket-core/src/main/java/net/airvantage/proxysocket/core/v2/ProxyProtocolV2Encoder.java

proxy-socket-core/src/test/java/net/airvantage/proxysocket/core/v2/ProxyProtocolV2Test.java

proxy-socket-core/src/main/java/net/airvantage/proxysocket/core/ProxyAddressCache.java

cthirouin-swi

I'ts fine, just couple of clarification.

proxy-socket-core/src/main/java/net/airvantage/proxysocket/core/v2/ProxyProtocolV2Decoder.java

proxy-socket-core/src/test/java/net/airvantage/proxysocket/core/v2/ProxyProtocolV2Test.java

sbernard31

I hope there are not too much nitpicking. 😅

I also feel that naming are not always consistent 😁

Some comments can eventually be done later in other PRs.

We can do a call if some point need to be discuss

LICENSE

README.md

.github/workflows/pull_requests.yml

...core/src/main/java/net/airvantage/proxysocket/core/cache/ConcurrentMapProxyAddressCache.java

proxy-socket-core/src/main/java/net/airvantage/proxysocket/core/v2/Tlv.java

.../src/test/java/net/airvantage/proxysocket/core/cache/ConcurrentMapProxyAddressCacheTest.java

proxy-socket-core/src/test/java/net/airvantage/proxysocket/core/v2/ProxyProtocolV2Test.java

Co-authored-by: Simon Bernard <code@simonbernard.eu>

…e/v2/ProxyHeader.java Co-authored-by: Simon Bernard <code@simonbernard.eu>

…e/v2/ProxyProtocolV2Decoder.java Co-authored-by: Simon Bernard <code@simonbernard.eu>

cthirouin-swi

Just couple of minor stuff.

proxy-socket-core/src/main/java/net/airvantage/proxysocket/core/v2/ProxyProtocolV2Decoder.java

.../src/test/java/net/airvantage/proxysocket/core/cache/ConcurrentMapProxyAddressCacheTest.java

proxy-socket-core/src/main/java/net/airvantage/proxysocket/core/v2/ProxyProtocolV2Decoder.java

Co-authored-by: cthirouin <113358856+cthirouin-swi@users.noreply.github.com>

proxy-socket-core/src/main/java/net/airvantage/proxysocket/core/v2/ProxyProtocolV2Decoder.java

...core/src/main/java/net/airvantage/proxysocket/core/cache/ConcurrentMapProxyAddressCache.java

sbernard31 · 2025-11-24T16:41:09Z

Last modification about usage of record could maybe be a not so good idea depending what we decide for : #7

But that sounds not a "prevent to merge" issue 🙂

cthirouin-swi

👍

bplessis-swi added 3 commits October 27, 2025 15:33

RAV-2958 - Initial Proxy Protocol processing

e18e18d

add spec link

887da06

:

fix tls constructor

a34382d

bplessis-swi self-assigned this Oct 27, 2025

bplessis-swi added 2 commits October 27, 2025 16:02

cleanup test

b3e5389

only test supported java releases

74755f0

bplessis-swi marked this pull request as ready for review October 27, 2025 15:06

bplessis-swi requested review from cthirouin-swi and sbernard31 November 3, 2025 16:21

cthirouin-swi reviewed Nov 6, 2025

View reviewed changes

bplessis-swi added 6 commits November 6, 2025 11:06

cleanup end of files spaces

b74f019

add test suite for basic cache

a4751e6

update readme

f260ccd

Split decoder in functions

5b8a9bb

Switch to external library for encoding headers in tests

9d7cd72

whitespaces

50e65a2

cthirouin-swi approved these changes Nov 7, 2025

View reviewed changes

proxy-socket-core/src/main/java/net/airvantage/proxysocket/core/v2/ProxyProtocolV2Decoder.java Outdated Show resolved Hide resolved

proxy-socket-core/src/test/java/net/airvantage/proxysocket/core/v2/ProxyProtocolV2Test.java Show resolved Hide resolved

sbernard31 reviewed Nov 13, 2025

View reviewed changes

bplessis-swi and others added 12 commits November 17, 2025 15:03

Update README.md

f4292cf

Co-authored-by: Simon Bernard <code@simonbernard.eu>

Fix license file, use leshan compatible BSD-3-Clause

c47fb02

Update proxy-socket-core/src/main/java/net/airvantage/proxysocket/cor…

47e6df3

…e/v2/ProxyHeader.java Co-authored-by: Simon Bernard <code@simonbernard.eu>

Update proxy-socket-core/src/main/java/net/airvantage/proxysocket/cor…

9029e73

…e/v2/ProxyHeader.java Co-authored-by: Simon Bernard <code@simonbernard.eu>

Update proxy-socket-core/src/main/java/net/airvantage/proxysocket/cor…

340dde3

…e/v2/ProxyProtocolV2Decoder.java Co-authored-by: Simon Bernard <code@simonbernard.eu>

take in account simon's review

eda9898

add serialVersionUID

b23bb8f

remove unused

4770613

add optional TLV parsing flag

128bcac

remove uneeded import

dbfe0f8

remove uneeded import

8876188

remove uneeded import

b1ccf69

bplessis-swi added 4 commits November 18, 2025 17:49

cleanup null test

beb2682

rename variable

e05039f

last cleanups

e0902be

cleanups

30ef605

bplessis-swi requested review from cthirouin-swi and sbernard31 November 19, 2025 15:41

cthirouin-swi requested changes Nov 20, 2025

View reviewed changes

bplessis-swi and others added 2 commits November 20, 2025 11:42

remove suggested unused imports

3098cb2

Co-authored-by: cthirouin <113358856+cthirouin-swi@users.noreply.github.com>

expand the throw to a block

175c850

sbernard31 mentioned this pull request Nov 21, 2025

Use Parameterized Tests for ProxyProtocolV2Test ? #5

Open

sbernard31 reviewed Nov 21, 2025

View reviewed changes

sbernard31 mentioned this pull request Nov 21, 2025

How we should behave with uncompliant / bad header #6

Open

bplessis-swi added 2 commits November 21, 2025 19:32

Take in account simon's review

77c6d8b

Use java 16 records

236e1ab

bplessis-swi requested review from cthirouin-swi and sbernard31 November 24, 2025 10:55

sbernard31 approved these changes Nov 24, 2025

View reviewed changes

cthirouin-swi approved these changes Nov 25, 2025

View reviewed changes

bplessis-swi merged commit 8149623 into main Nov 25, 2025
3 checks passed

bplessis-swi deleted the RAV-2958 branch November 25, 2025 09:20

RAV-2958 - Initial Proxy Protocol processing #1

RAV-2958 - Initial Proxy Protocol processing #1

Uh oh!

Conversation

bplessis-swi commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cthirouin-swi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cthirouin-swi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sbernard31 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cthirouin-swi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sbernard31 commented Nov 24, 2025

Uh oh!

cthirouin-swi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bplessis-swi commented Oct 27, 2025 •

edited

Loading

sbernard31 left a comment •

edited

Loading

cthirouin-swi left a comment •

edited

Loading