feature: added the capability to change the timeout so that the MCP server can wait for long running command #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver can wait for long running command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Commands that produce output gradually (e.g., apt update, npm install, build scripts) were failing with exit code 255 because execFileAsync buffers all output until completion. This caused SSH connections to close prematurely due to perceived inactivity.
Changed:
Replace buffered execution with streaming:
Use spawn instead of execFileAsync to consume output in real-time
Add 10MB output size limit with truncation message if exceeded
Return exit code 124 on timeout (standard convention)
Allow users to specify custom timeout via the timeout parameter