Draft
Conversation
…orporating in DeconvBin. Defined an initialize_solver function.
…ting self._solver. Started refactoring _compute_err to optimize numerical computations and readability.
… inference steps in the Deconv class to their own file (thres_and_solv.py). Started by refactoring max_thres. Other functions I am working on are solv, _max_thres, and solve_thres, all of which are part of the deconv.py file.
…ere it doesn't initialize. I keep getting this: AttributeError: 'NoneType' object has no attribute 'shape' indeca\core\deconv\solver.py:596: AttributeError
…on benchmarking scripts with real data.
…plemented as it is currently not working. Raising issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redux of refactoring parameters into a single dataclass that can be passed through functions efficiently.