Skip to content

Comments

Parameter object refactoring#55

Closed
kaghi wants to merge 6 commits intodataclass-refactorfrom
main
Closed

Parameter object refactoring#55
kaghi wants to merge 6 commits intodataclass-refactorfrom
main

Conversation

@kaghi
Copy link
Contributor

@kaghi kaghi commented Jan 27, 2026

Ensuring parameters are efficiently called and passed through functions without having to generate them multiple times.

phildong and others added 6 commits December 31, 2025 11:47
* relax test_solve_thres time distance tolerance
* disable prob matrix nnz entry checking when re-setup problem
* reset weight truncate threshold and min relative scale to None
---------

Co-authored-by: phildong <phildong@users.noreply.github.com>
@sneakers-the-rat
Copy link
Contributor

sneakers-the-rat commented Jan 28, 2026

just a heads up - looks like your branches are reversed: this is trying to pull from main into dataclass-refactor, when you want the other way around: do work in dataclass-refactor and then merge it into main.

it also looks like the dataclass-refactor branch is missing the last 6 commits in main, so you'll want to rebase on main/merge main into the dataclass-refactor branch

@kaghi
Copy link
Contributor Author

kaghi commented Jan 28, 2026

Got it, thank you for the heads up.

@kaghi
Copy link
Contributor Author

kaghi commented Jan 28, 2026

deleting this branch bc deconv is sufficiently diff and it wouldnt make sense to continue. I will start a new PR with a new dataclass-refactor branch and then continue refactoring there.

@kaghi kaghi closed this Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants