fix: 若retryFunc未被执行，返回一个err避免后续的空引用错误#55
Open
smiley-yoyo wants to merge 1 commit intoAgoraIO-Community:mainfrom
Open
fix: 若retryFunc未被执行，返回一个err避免后续的空引用错误#55smiley-yoyo wants to merge 1 commit intoAgoraIO-Community:mainfrom
smiley-yoyo wants to merge 1 commit intoAgoraIO-Community:mainfrom
Conversation
smiley-yoyo
commented
Jan 30, 2026
smiley-yoyo
commented
- 若retry.Do(retryFunc, stopFunc...)中的retryFunc未被执行，其中的baseResponse未能赋值因此为nil
- 又stopFunc判断在retryFunc之前，因此有较高的概率发生baseResponse为nil的情况，例如context canceled的情况
- 因此有必要在retryFunc未执行的情况下返回一个err，以拦截baseResponse的nil引用
1. 若retry.Do(retryFunc, stopFunc...)中的retryFunc未被执行，其中的baseResponse未能赋值因此为nil 2. 又stopFunc判断在retryFunc之前，因此有较高的概率发生baseResponse为nil的情况，例如context canceled的情况 3. 因此有必要在retryFunc未执行的情况下返回一个err，以拦截baseResponse的nil引用
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.