Conversation
- Wire up AgentService + ToolRegistry + WeatherTool in CLI entry point - Fix AgentService: don't yield Done on intermediate tool calling rounds, which caused ChatBloc to stop listening before final response - Fix WeatherTool: use Uri.https() for proper URL encoding of city names (fixes Chinese characters and spaces in city names) - Add null check for lat/lon when city not found Co-Authored-By: Claude Code <noreply@anthropic.com>
mintminterdev
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentService+ToolRegistry+WeatherToolin CLI entry pointDoneon intermediate tool calling rounds, causing ChatBloc to stop listening before the final text response arrived. NowDoneis only yielded on the final round.Uri.https()instead of string concatenation +Uri.parse()for proper encoding of Chinese characters and spaces in city namesTest plan
dart analyzepasses (chat_core + skewr_cli)dart format --set-exit-if-changed .passesdart test— chat_core: 63 tests passed, skewr_cli: 10 tests passed🤖 Generated with Claude Code
Co-Authored-By: Claude Code noreply@anthropic.com