Skip to content

fix: account for skipped papers in novelty index validation #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ruizhengu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: account for skipped papers in novelty index validation #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Paper-KG-Pipeline/src/idea2paper/infra/index_preflight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,11 @@ def validate_novelty_index(index_dir: Path, nodes_paper_path: Path, embedding_mo
if manifest.get("index_count") is not None and meta_count != int(manifest.get("index_count")):
result["reason"] = "incomplete"
return result
if manifest.get("paper_count") is not None and int(manifest.get("paper_count")) != int(manifest.get("index_count")):
result["reason"] = "incomplete"
return result
if manifest.get("paper_count") is not None and manifest.get("index_count") is not None:
expected = int(manifest.get("index_count")) + int(manifest.get("skipped", 0))
if int(manifest.get("paper_count")) != expected:
result["reason"] = "incomplete"
return result

result["ok"] = True
result["reason"] = "ok"
Expand Down