Migrate fast_plan_tasks to AgentField native .harness() (#28)#31
Conversation
|
I have read the CLA Document and I hereby sign the CLA Note to Maintainers: The This appears to be an infrastructure issue where the workflow lacks the necessary PAT to write to the centralized |
|
Hey @Parth-Vasave 👋 We just migrated our CLA setup — the old check you're seeing is from a workflow we've since removed, so you can ignore it. Could you quickly sign the new CLA here? 👉 https://cla-assistant.io/Agent-Field/SWE-AF Once signed, the new |
|
@santoshkumarradha signed the new CLA, please reveiw when you can! :) |
|
CC @AbirAbbas |
|
sorry for the delay, taking a look |
AbirAbbas
left a comment
There was a problem hiding this comment.
Reviewed and tested locally. Fast planner migration to harness() works correctly — fallback path exercised end-to-end via live docker test (12/12 steps, 0 failures). LGTM.
Changes
fast_plan_tasksagent inswe_af/fast/planner.pyfrom the customAgentAIabstraction to the nativefast_router.harness()method. Updated the test suite (tests/fast/test_planner.py,tests/test_malformed_responses.py) to mock the new implementation and added fixtures intests/conftest.pyandtests/fast/conftest.pyto ensure routers are correctly attached during tests..harness()and remove reliance on custom execution abstractions, as part of the broader migration effort (Migrate fast/ module (fast_plan_tasks) to AgentField native .harness() #28).Validation
make check(778 passed, 1 skipped, 1 warning)fast_plan_taskssuccess and fallback paths verified.Behavior Impact
Notes
try-exceptaroundfast_routerattribute access inplanner.pyto prevent telemetry overhead from blocking execution if a router is unattached.attach_fast_routerfixture was added to both root and nestedconftest.pyto resolveRuntimeError: Router not attachedwhich occurs whenunittest.mock.patchinspects an unattached router.