Fix permission_mode propagation and isolate iteration checkpoints by build id#20
Merged
AbirAbbas merged 2 commits intoAgent-Field:mainfrom Feb 26, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Two small fixes to make coding-loop execution deterministic across builds:
permission_modeis now propagated from build config into coder/reviewer/QA/synthesizer calls.build_idto prevent stale resume state leaking between builds.Included tests
test_run_coding_loop_propagates_permission_mode_to_all_agentstest_run_coding_loop_ignores_legacy_iteration_state_when_build_id_presentValidation
AGENTFIELD_SERVER=http://localhost:9999 pytest -q tests/test_coding_loop_regressions.py(2 passed)ruff checkon touched files (clean)Summary
This PR fixes two execution-loop issues that can cause inconsistent behavior across builds:
permission_modefrom build config was not being propagated into coding-loop agent calls.Changes
permission_modethrough execution config plumbing:permission_modeinBuildConfig.to_execution_config_dict().config.permission_modein coder/reviewer/QA/synthesizer calls.execution/iterations/<build_id>/<issue>.json.dag_state.build_id.Why this is safe
build_idis available (fallback path still exists).