Skip to content

Migrate fast_plan_tasks to AgentField native .harness() (#28)#31

Merged
AbirAbbas merged 1 commit intoAgent-Field:mainfrom
Parth-Vasave:migrate-fast-planner-harness
Mar 12, 2026
Merged

Migrate fast_plan_tasks to AgentField native .harness() (#28)#31
AbirAbbas merged 1 commit intoAgent-Field:mainfrom
Parth-Vasave:migrate-fast-planner-harness

Conversation

@Parth-Vasave
Copy link
Copy Markdown
Contributor

Changes

  • What changed: Migrated the fast_plan_tasks agent in swe_af/fast/planner.py from the custom AgentAI abstraction to the native fast_router.harness() method. Updated the test suite (tests/fast/test_planner.py, tests/test_malformed_responses.py) to mock the new implementation and added fixtures in tests/conftest.py and tests/fast/conftest.py to ensure routers are correctly attached during tests.
  • Why it changed: To leverage AgentField's first-class support for .harness() and remove reliance on custom execution abstractions, as part of the broader migration effort (Migrate fast/ module (fast_plan_tasks) to AgentField native .harness() #28).

Validation

  • make check (778 passed, 1 skipped, 1 warning)
  • Unit tests for fast_plan_tasks success and fallback paths verified.

Behavior Impact

  • Backward compatible behavior change (Internal refactoring of agent execution while preserving schemas and fallback logic).

Notes

  • Added a defensive try-except around fast_router attribute access in planner.py to prevent telemetry overhead from blocking execution if a router is unattached.
  • The attach_fast_router fixture was added to both root and nested conftest.py to resolve RuntimeError: Router not attached which occurs when unittest.mock.patch inspects an unattached router.

@Parth-Vasave Parth-Vasave requested a review from AbirAbbas as a code owner March 9, 2026 18:16
@Parth-Vasave Parth-Vasave changed the title fixes Migrate fast/ module (fast_plan_tasks) to AgentField native .ha… Migrate fast_plan_tasks to AgentField native .harness() (#28) Mar 9, 2026
@Parth-Vasave
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA


Note to Maintainers: The CLA Assistant workflow is currently failing with a configuration error:
Error: Please add a personal access token as an environment variable for writing signatures in a remote repository...

This appears to be an infrastructure issue where the workflow lacks the necessary PAT to write to the centralized Agent-Field/.github repository. All technical tests (make check) are passing locally.

@santoshkumarradha
Copy link
Copy Markdown
Member

Hey @Parth-Vasave 👋

We just migrated our CLA setup — the old check you're seeing is from a workflow we've since removed, so you can ignore it.

Could you quickly sign the new CLA here? 👉 https://cla-assistant.io/Agent-Field/SWE-AF

Once signed, the new license/cla check should pick up automatically. Thanks for the contribution!

@Parth-Vasave
Copy link
Copy Markdown
Contributor Author

@santoshkumarradha signed the new CLA, please reveiw when you can! :)

@santoshkumarradha
Copy link
Copy Markdown
Member

CC @AbirAbbas

@AbirAbbas
Copy link
Copy Markdown
Collaborator

sorry for the delay, taking a look

Copy link
Copy Markdown
Collaborator

@AbirAbbas AbirAbbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested locally. Fast planner migration to harness() works correctly — fallback path exercised end-to-end via live docker test (12/12 steps, 0 failures). LGTM.

@AbirAbbas AbirAbbas merged commit 3ed4827 into Agent-Field:main Mar 12, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants