add opentelemetry tracing #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jun 12, 2025
Member
jplatte
left a comment
jplatte
left a comment
There was a problem hiding this comment.
Would be nice if this could be split into smaller chunks, as reviewing such a big commit is really hard.
| } | ||
| } | ||
| }); | ||
| .instrument(Span::current()), |
Member
There was a problem hiding this comment.
Suggested change
| .instrument(Span::current()), | |
| .in_current_span(), |
https://docs.rs/tracing/latest/tracing/trait.Instrument.html#method.in_current_span
Collaborator
Author
Yeah 😅 I can probably break it into 2 PRs... one for getting tracing working in the bare minimum, then one which adds all the tracing improvements in each service to have the traces make more sense |
Member
|
@tarkah Needs a rebase it looks like? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.