v5 - UPI auto detect - UI#2659
Open
OscarSpruit wants to merge 3 commits intochore/upi-auto-detectfrom
Open
Conversation
COSDK-1092
COSDK-1092
COSDK-1092
OscarSpruit
added
the
Chore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the GenericApp functionality from the UPI intent flow, simplifying the delegate, adapter, and model logic. The UI is updated to replace the RadioButton with a checkmark ImageView in the app list, and a new list title is introduced. Feedback highlights the use of hardcoded strings for the list title and accessibility descriptions, which should be moved to string resources for localization.
Contributor
✅ No public API changes |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the UI for UPI intent to reflect the new designs.
NOTE: Translations will be added in a follow up PR. This branch will be merged into a feature branch.
Checklist
Ticket Number
COSDK-1092