v5 - Co-badged cards - Dual branded disclaimer#2658
Merged
araratthehero merged 2 commits intofeature/co-badged-cardsfrom Apr 2, 2026
Merged
v5 - Co-badged cards - Dual branded disclaimer#2658araratthehero merged 2 commits intofeature/co-badged-cardsfrom
araratthehero merged 2 commits intofeature/co-badged-cardsfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a BrandState sealed class to encapsulate card brand UI states and adds a disclaimer view for dual-branded cards. The BrandView was refactored to use this new state, and visibility logic for the disclaimer was integrated into CardView. A review comment identifies redundant visibility logic for the disclaimer in the card number validation method, suggesting it be centralized in the brand update function.
…ggle it when card is dual branded and selectable COSDK-1062
3ea664c to
ced207d
Compare
Contributor
✅ No public API changes |
|
jreij
reviewed
Apr 1, 2026
Base automatically changed from
chore/co-badged-cards-card-scanning
to
feature/co-badged-cards
April 1, 2026 14:55
jreij
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Checklist
Ticket Number
COSDK-1062