Skip to content

v5 - Co-badged cards - Dual branded disclaimer#2658

Merged
araratthehero merged 2 commits intofeature/co-badged-cardsfrom
chore/co-badged-cards-disclaimer
Apr 2, 2026
Merged

v5 - Co-badged cards - Dual branded disclaimer#2658
araratthehero merged 2 commits intofeature/co-badged-cardsfrom
chore/co-badged-cards-disclaimer

Conversation

@araratthehero
Copy link
Copy Markdown
Contributor

Description

  • Disclaimer has been added below the card number field which appears only when the card is dual branded and selectable.
  • Disclaimer hides when there is an error in the card number field
  • BrandVIew state has been added and the logic moved to CardView to allow controlling the CardView behavior

Checklist

  • Changes are tested manually

Ticket Number

COSDK-1062

@AdyenAutomationBot AdyenAutomationBot added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label Mar 30, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a BrandState sealed class to encapsulate card brand UI states and adds a disclaimer view for dual-branded cards. The BrandView was refactored to use this new state, and visibility logic for the disclaimer was integrated into CardView. A review comment identifies redundant visibility logic for the disclaimer in the card number validation method, suggesting it be centralized in the brand update function.

…ggle it when card is dual branded and selectable

COSDK-1062
@araratthehero araratthehero force-pushed the chore/co-badged-cards-disclaimer branch from 3ea664c to ced207d Compare March 30, 2026 14:04
@araratthehero araratthehero marked this pull request as ready for review March 30, 2026 14:05
@araratthehero araratthehero requested a review from a team as a code owner March 30, 2026 14:05
@github-actions
Copy link
Copy Markdown
Contributor

✅ No public API changes

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Base automatically changed from chore/co-badged-cards-card-scanning to feature/co-badged-cards April 1, 2026 14:55
@araratthehero araratthehero merged commit ee56702 into feature/co-badged-cards Apr 2, 2026
16 of 17 checks passed
@araratthehero araratthehero deleted the chore/co-badged-cards-disclaimer branch April 2, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants