v5 - Co-badged cards - Card scanning button behaviour#2657
Open
araratthehero wants to merge 2 commits intochore/co-badged-cards-add-to-card-viewfrom
Open
v5 - Co-badged cards - Card scanning button behaviour#2657araratthehero wants to merge 2 commits intochore/co-badged-cards-add-to-card-viewfrom
araratthehero wants to merge 2 commits intochore/co-badged-cards-add-to-card-viewfrom
Conversation
…e DefaultCardDelegate COSDK-1062
AdyenAutomationBot
added
the
Chore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements logic to manage the visibility of the card scanning interface, ensuring the scan button is only shown when scanning is available and the card number field is empty. Changes include state management in the card delegates, updates to the output data model, and UI adjustments in CardView and CardScanningFragment. A critical feedback item identifies a potential crash in CardScanningFragment due to unsafe binding access after the view lifecycle has ended, suggesting a null-safe approach.
card/src/main/java/com/adyen/checkout/card/internal/ui/view/CardScanningFragment.kt
Show resolved
Hide resolved
…ibility from CardDelegate COSDK-1062
araratthehero
force-pushed
the
chore/co-badged-cards-card-scanning
branch
from
d2c3c17 to
852511e
Compare
Contributor
✅ No public API changes |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need to hide and show the card scanning and brand icons based on the following states.
Checklist
Ticket Number
COSDK-1062