Skip to content

v5 - Co-badged cards - Add brand view to the card view#2656

Open
araratthehero wants to merge 2 commits intofeature/co-badged-cardsfrom
chore/co-badged-cards-add-to-card-view
Open

v5 - Co-badged cards - Add brand view to the card view#2656
araratthehero wants to merge 2 commits intofeature/co-badged-cardsfrom
chore/co-badged-cards-add-to-card-view

Conversation

@araratthehero
Copy link
Copy Markdown
Contributor

Description

  • Added BrandView to the CardView
  • Adjusted some margins/paddings to match the design
Screenshot_20260325_115520

Checklist

  • Changes are tested manually

Ticket Number

COSDK-1062

@araratthehero araratthehero requested a review from a team as a code owner March 26, 2026 14:51
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the card input experience by introducing explicit support for co-badged cards. It integrates a dedicated brand selection view within the card form, enabling users to choose their preferred card brand. Additionally, minor UI adjustments were made to ensure visual consistency and adherence to design guidelines.

Highlights

  • Brand View Integration: Integrated a new BrandView component into the CardView to support co-badged cards, allowing users to select between different card brands.
  • UI Adjustments: Refined the layout and styling of card elements by adjusting margins and paddings to align with the design specifications.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@AdyenAutomationBot AdyenAutomationBot added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

✅ No public API changes

@araratthehero araratthehero marked this pull request as draft March 26, 2026 14:59
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates a new BrandView component into the CardView to display and manage card brand selection, including support for dual-brand cards. It involves adding the BrandView to the layout, initializing its behavior, and updating it with detected card types and environment data. A suggestion was made to optimize the BrandView by passing the Environment parameter only once during initialization, as it does not change during the CardView's lifecycle, instead of on every update.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@araratthehero araratthehero marked this pull request as ready for review March 27, 2026 10:24
Base automatically changed from chore/co-badged-cards-brand-list-view to feature/co-badged-cards March 27, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants