Conversation
There is always a chevron displayed and optionally for some payment methods some brand icons can be displayed.
This will ensure icons with a transparent icon will have a proper background and are not displayed on top of the drop shadow.
This ensures all payment methods are displayed the same. Before Pay by bank US would only display a "+" as the brands don't come from the backend.
OscarSpruit
added
the
Chore
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience of the payment method list by visually enriching each entry. It introduces brand icons for card and Pay by Bank US payment methods, making it easier for users to identify their preferred options. Additionally, a chevron icon has been added to each list item, providing a clear visual cue for navigability. These changes aim to improve the clarity and usability of the payment method selection process. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
✅ No public API changes |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request enhances the payment method list UI by adding a background to network logos, introducing spacing between list items, and displaying associated payment method brands with a chevron icon for navigation. The view model and state were updated to support this new brand information, and a new drawable for the chevron icon was added. A critical accessibility issue was identified where the newly added chevron icon lacks a meaningful contentDescription, making it inaccessible to screen readers.
drop-in/src/main/java/com/adyen/checkout/dropin/internal/ui/PaymentMethodListScreen.kt
Show resolved
Hide resolved
|
| } | ||
| } | ||
|
|
||
| private const val AMOUNT_VISIBLE_BRANDS = 3 |
There was a problem hiding this comment.
Is it intended that this constant is in the middle of the file?
There was a problem hiding this comment.
Put it there to keep it close to where it's used. I can put it on top as well to align with standard conventions. What do you prefer?
2 participants
Description
This PR will make the payment method list display brand icons for the card and pay by bank US payment methods. Also, every item now displays a chevron