Skip to content
This repository was archived by the owner on Jan 6, 2022. It is now read-only.

Comments

Prose conversion#313

Open
Hackin7 wants to merge 8 commits intoAdvisorySG:masterfrom
Hackin7:prose-conversion
Open

Prose conversion#313
Hackin7 wants to merge 8 commits intoAdvisorySG:masterfrom
Hackin7:prose-conversion

Conversation

@Hackin7
Copy link
Contributor

@Hackin7 Hackin7 commented Oct 8, 2021

For now I edited the error.hbs to use the prose class. I have also updated tailwind.config.js so that the prose class doesn't overwrite the inner classes as much

Screenshot (13)

@Hackin7 Hackin7 linked an issue Oct 8, 2021 that may be closed by this pull request
@Hackin7 Hackin7 marked this pull request as ready for review October 9, 2021 08:53
@wei2912 wei2912 self-requested a review October 9, 2021 08:57
@wei2912 wei2912 added the enhancement New feature or request label Oct 9, 2021
@wei2912
Copy link
Member

wei2912 commented Oct 16, 2021

One current issue with the use of the prose class is that the font family of the headings are different (see the below two images for comparison):

image

(with prose)

image

(without prose)

Before this PR can be merged, the font families and sizes will need to be standardised.

@wei2912
Copy link
Member

wei2912 commented Oct 16, 2021

Practically all pages, other than home.hbs and page-stories.hbs, are already using the prose class for all typography. Moving forward, I think we can continue to adopt the use of prose for multiple paragraphs of text while avoiding its use for more complex components, e.g. article display.

Copy link
Member

@wei2912 wei2912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the above comments, thanks! Let me know if you have any queries on what to change.

@Hackin7
Copy link
Contributor Author

Hackin7 commented Oct 25, 2021

For now I'm still not too sure of the best way to do it, but in home.hbs and page-stories.hbs, I made the headings use the prose class (by wrapping the heading around a span element with the prose class)
This way, the overall style can be customised by modifying the prose class in tailwind.config.js

image
image
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate pages to use prose class in Tailwind typography plugin

2 participants