This repository was archived by the owner on Jan 6, 2022. It is now read-only.
Conversation
partysnax
suggested changes
Jun 13, 2021
Contributor
There was a problem hiding this comment.
You can view the error message by triggering error 404, such as visiting any page that doesn't exist on your local instance eg. localhost:2368/abcd/
The original error screen for reference:

I feel that to best match the original design in error.hbs :
- In line 3 under the
sectiontag, the classescontent-centercan be removed (redundant) andproseshould be removed (adds unnecessary margins between each line of text) - Line 4: Give the
statusCodethe classtext-6xl - Line 5: Give the
messagethe classestext-gray-400 text-xl
These are just suggestions, feel free to fine tune them
Member
Author
|
@partysnax Thanks for the review! I was looking to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
assets/css/ghost/errors.cssand replaces the classes with somewhat equivalent CSS styles.Tbh I haven't tested the theme error stack as I have no idea how to trigger that error.