-
Notifications
You must be signed in to change notification settings - Fork 4
perform scaling of the object step length for LSTSQ multislice in a similar way as FoldSlice #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/ptychi/api/options/lsqml.py
Outdated
| If True, object and probe step sizes will only be calculated using the first probe mode. | ||
| """ | ||
|
|
||
| beta_LSQ: float = 0.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
step_size already does this so we don't need a separate parameter. I will revert this.
…tio to PtychoShelves
…on without step size modification; apply step size only in `apply_object_update`
…default; merge single/multislice functions
… storage to PtychoShelves; fix errors in step size solver, OPR update, momentum acceleration
e65f542 to
001ef2e
Compare
ChangesChanges are made to match PtychoShelves in the following discrepancies found between the two packages:
For the most updated list of discrepancies, see https://git.aps.anl.gov/ptycho_software/pty-chi/-/issues/32. API changes
|
…ake remove environment step always run
In FoldSlice, when computing LSTSQ multislice steplengths (using either the joint probe/object steplength computation or the non-joint), they divide the computed object step length by the number of slices and the number of probe modes.
I include this scaling in LSTSQ multislice for this pull request.