Open
Conversation
update
naming in scss for better overview in the css file
This reverts commit ac8024f.
aniWeyn
approved these changes
May 11, 2023
|
|
||
| The project uses amongst other things HTML, CSS and JavaScript, so it is **recommended** that you have a basic understanding of these technologies before diving in. | ||
|
|
||
| ## Instructions[^1]: |
| The objective of this project is to design a webpage using only CSS **without** using any additional JavaScript code. This means that all the dynamic and interactive features of the webpage should be created solely using CSS styling and animations. This can be a challenging task, but it allows for a more lightweight and efficient webpage that loads faster and has better performance. It also provides an opportunity to showcase advanced CSS skills and techniques. With careful planning and creativity, it is possible to create a visually appealing and engaging webpage using only CSS. | ||
|
|
||
| # Where users can get help with your project | ||
| If you have any questions or issues related to the "United Nations Goal 13: Climate Action" project, you can reach out to the project maintainer, Eva. She is available to provide guidance, support, and feedback to users who are interested in contributing to the project. You can contact Eva through the project's GitHub page, by opening an issue or pull request, or by sending a [direct message](https://github.com/evafha). |
| <!--Photo by <a href="https://unsplash.com/@chrisleboutillier?utm_source=unsplash&utm_medium=referral&utm_content=creditCopyText">Chris LeBoutillier</a> on <a href="https://unsplash.com/photos/c7RWVGL8lPA?utm_source=unsplash&utm_medium=referral&utm_content=creditCopyText">Unsplash</a>--> | ||
|
|
||
|
|
||
| <img src="assets/images/forest.jpg" alt="parched and cut down forest" loading="lazy"> |
| } | ||
| }) | ||
| }, { | ||
| threshold: 0.4 |
There was a problem hiding this comment.
very nice that you have added comments to intersection observer, because of that would be nice as well to add the comment on why you have choosen threshold to level 0.4, and why have you adjusted only one option and left others as default
Comment on lines
+5
to
+9
| --background-one: #9aac8a; | ||
| --background-two: #49733d; | ||
| --background-three: #bdd2ea; | ||
| --background-five: #4f99cc; | ||
| --background-six: #9aac8a; |
There was a problem hiding this comment.
good to have more descriptive names than -one, -two, -three etc. :)
There was a problem hiding this comment.
nice that CSS Variables are used, would be better if there will be more implementations, not only for colors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @evafha