Skip to content

Feedback#1

Open
github-classroom[bot] wants to merge 8 commits intofeedbackfrom
main
Open

Feedback#1
github-classroom[bot] wants to merge 8 commits intofeedbackfrom
main

Conversation

@github-classroom
Copy link
Copy Markdown
Contributor

@github-classroom github-classroom bot commented May 1, 2023

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers

Use this PR to leave feedback. Here are some tips:

  • Click the Files changed tab to see all of the changes pushed to main since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.
  • Click the Commits tab to see the commits pushed to main. Click a commit to see specific changes.
  • If you turned on autograding, then click the Checks tab to see the results.
  • This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below.
    For more information about this pull request, read “Leaving assignment feedback in GitHub”.

Subscribed: @VegardTheMonkey

@VegardTheMonkey VegardTheMonkey temporarily deployed to github-pages May 4, 2023 01:36 — with GitHub Pages Inactive
Copy link
Copy Markdown

@aniWeyn aniWeyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 👏 👏 👏 👏

Comment on lines +43 to +45
<h3>Pleas for</h3>
<h1>Global peace</h1>
<h2>Grow louder</h2>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very bad practice, you should not place <h1> below other types of headers

Comment on lines +97 to +99
<h2>a record</h2>
<h1 class="stat3">100 million people</h1>
<h2>had been forcibly<br>displaced worldwide<br>(may 2022)</h2>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to HTML standards, the h1 tag should typically be used to represent the main heading of a page or section. While it is technically possible to use the h1 tag more than once on a page, it is generally recommended to use it only once per page and to use lower-level heading tags (h2, h3, etc.) for subheadings.

Using multiple h1 tags on a page can be confusing for both users and search engines because it makes it unclear which heading is the most important one. It can also affect the accessibility of the page, as some screen readers and other assistive technologies rely on headings to navigate content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants