Skip to content
This repository was archived by the owner on Jun 17, 2024. It is now read-only.

add deprecation notice to casks#540

Open
gdams wants to merge 2 commits intoAdoptOpenJDK:masterfrom
gdams:deprecate
Open

add deprecation notice to casks#540
gdams wants to merge 2 commits intoAdoptOpenJDK:masterfrom
gdams:deprecate

Conversation

@gdams
Copy link
Member

@gdams gdams commented Aug 17, 2021

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

@gdams gdams marked this pull request as draft August 17, 2021 10:29
@gdams
Copy link
Member Author

gdams commented Aug 17, 2021

Keeping in draft until I know the strategy for openj9 casks

@drothmaler
Copy link

Shouldn't the deprecation messages reference the closest available temurin version?

At least for the LTS Versions:

  • adoptopenjdk8 --> temurin8
  • adoptopenjdk11 --> temurin11
  • adoptopenjdk17 --> temurin17

For adoptopenjdk13-16 I'd probably recommend temurin17 as the closest LTS Version...

@karianna karianna marked this pull request as ready for review September 25, 2023 02:52
@karianna
Copy link
Member

@gdams LMK if I can help wrap this up

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants