AC-16115: Adobe Development Doc - Message Queues - ActiveMq (Artemis) updates 2.4.5#426
AC-16115: Adobe Development Doc - Message Queues - ActiveMq (Artemis) updates 2.4.5#426meker12 merged 45 commits intoAdobeDocs:mainfrom
Conversation
sandesh-as
changed the title
|
@meker12 Updated Description |
|
@meker12 can you please review this Pr |
src/pages/development/components/message-queues/async-configuration.md
Outdated
Show resolved
Hide resolved
src/pages/development/components/message-queues/bulk-operations-example.md
Outdated
Show resolved
Hide resolved
src/pages/development/components/message-queues/configuration.md
Outdated
Show resolved
Hide resolved
|
@meker12, is there anything else required from my side, or can we proceed with merging this PR? |
github-project-automation
bot
moved this from 📋 Needs Review
to 🏁 Done
in Commerce - Pull Requests
github-project-automation
bot
moved this from 🏁 Done
to 🧑💻 In Progress
in Commerce - Pull Requests
src/pages/development/components/message-queues/async-configuration.md
Outdated
Show resolved
Hide resolved
src/pages/development/components/message-queues/configuration.md
Outdated
Show resolved
Hide resolved
Fix filename
Refactor bulk-operations-example documentation - Update frontmatter description to be action-oriented - Simplify section introductions and descriptions - Remove redundant "Create" prefix from XML config subsections - Fix grammar in cross-reference link text - Merge two InlineAlert blocks into single consolidated note
Refactor async-configuration.md for clarity and consistency - Fix typos: ampqp→amqp, queue_customer→queue_consumer - Correct heading hierarchy for queue_topology.xml section - Remove redundant config file listing in introduction - Improve sentence structure and documentation style
|
@dshevtsov looks like this repository is in the process of EDS migration. This PR is a significant update. How can we ensure that the updates get migrated? |
Fix markdown error.
meker12
added
technical
github-project-automation
bot
moved this from 👍 Approved
to 🏁 Done
in Commerce - Pull Requests
github-project-automation
bot
moved this from 🏁 Done
to 🧑💻 In Progress
in Commerce - Pull Requests
meker12
left a comment
meker12
left a comment
There was a problem hiding this comment.
Check and update PHP code examples.
Comments about the code samples from GitHub copilot:
Examples & accuracyProblem: Many examples show explicit connection names (amqp/stomp/db) — ensure these match actual supported values in the code and exact env.php field names (confirm whether the key is default_connection or default or default_connection under ‘queue’).Suggested fix: Verify field names and semantics against the implementation (ConfigInterface/env.php schema) and align examples.
Schema validity (publisher/connection examples)Problem: Several examples omit the connection name in a element for AMQP, or present a element while the documentation also suggests omitting the element is acceptable. This leads to ambiguity and an example that might be invalid per publisher.xsd.Suggested fix: For every example that includes a element show a fully valid element (include name=“amqp” when explicitly specifying AMQP), and explicitly show the “omit connection element to use env.php default” alternative.
Specific to dos:
In bulk-operations-example.md change the AMQP publisher example to either:omit the connection element entirely (and add a comment line that env.php determines the active connection), or
include a valid connection element: [5:44 AM]2. Confirm and standardize the env.php example structure (keys and default_connection naming) against the product implementation and update examples accordingly.
github-project-automation
bot
moved this from 🧑💻 In Progress
to 🛠 Changes Requested
in Commerce - Pull Requests
@meker12 the migration branch is in-sync with main, so no content will be lost during migration. |
|
Hi @meker12, I have updated the examples. |
|
@meker12 can you please review |
src/pages/development/components/message-queues/configuration.md
Outdated
Show resolved
Hide resolved
meker12
left a comment
meker12
left a comment
There was a problem hiding this comment.
Looks good @sandesh-as. Thank you!
github-project-automation
bot
moved this from 🛠 Changes Requested
to 👍 Approved
in Commerce - Pull Requests
github-project-automation
bot
moved this from 👍 Approved
to 🏁 Done
in Commerce - Pull Requests
4 participants
Purpose of this pull request
[AC-16115]::Adobe Development Doc - Message Queues - ActiveMq (Artemis) updates
Updates the Commerce Message Queues documentation to add support for ActiveMQ Artemis (STOMP) message broker.
Affected pages
whats new
Updated the following topics in the Message Queues guide to document support for ActiveMQ Artemis added to Commerce versions 2.4.5+.