Skip to content

fix : video has extra black height above and below #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BaskarMitrah wants to merge 2 commits into from
Closed

fix : video has extra black height above and below #569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebe7751
fix : video blank issue
BaskarMitrah Mar 25, 2026
ec2bde6
update : aspect ratio
BaskarMitrah Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion hlx_statics/blocks/iframe/iframe.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,11 @@ main div.iframe-wrapper .iframe-custom-width{
display: flex;
align-items: center;
justify-content: center;
}
}

/* 16:9 only for iframe blocks authored with the aspect-video variant;
skip when data-height is set (.iframe-has-explicit-height) or YouTube (.youtube-iframe). */
main div.iframe-wrapper iframe.iframe-container.aspect-video:not(.youtube-iframe):not(.iframe-has-explicit-height) {
height: auto !important;
aspect-ratio: 16 / 9;
}
6 changes: 4 additions & 2 deletions hlx_statics/blocks/iframe/iframe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,12 @@ export default async function decorate(block) {
}

if (width) {
iframe.style.width = width;
iframe.style.setProperty('width', width, 'important');
}
if (height) {
iframe.style.height = height;
iframe.classList.add('iframe-has-explicit-height');
iframe.style.setProperty('height', height, 'important');
iframe.classList.add('iframe-has-explicit-height');
}

penpalScript.onload = () => {
Expand Down
Loading