Conversation
setup project
add functionality
aitemr
reviewed
Mar 19, 2023
| import UIKit | ||
| import SnapKit | ||
|
|
||
| class AlbumCellHeader: UICollectionReusableView { |
aitemr
reviewed
Mar 19, 2023
| return button | ||
| }() | ||
|
|
||
| override init(frame: CGRect) { |
aitemr
reviewed
Mar 19, 2023
| return image | ||
| }() | ||
|
|
||
| lazy var title: UILabel = { |
There was a problem hiding this comment.
titleLabel, если будет просто title как будто данные из модели, лучше всегда делать привзяку UI элементам
aitemr
reviewed
Mar 19, 2023
| return label | ||
| }() | ||
|
|
||
| lazy var quantity: UILabel = { |
aitemr
reviewed
Mar 19, 2023
| return stack | ||
| }() | ||
|
|
||
| override init(frame: CGRect) { |
aitemr
reviewed
Mar 19, 2023
|
|
||
| override init(frame: CGRect) { | ||
| super.init(frame: frame) | ||
| clipsToBounds = true |
There was a problem hiding this comment.
это точно нужно? лучше его в метод setupviews
aitemr
reviewed
Mar 19, 2023
|
|
||
| static let identifier = "AlbumCollectionViewCell" | ||
|
|
||
| lazy var image: UIImageView = { |
There was a problem hiding this comment.
лучше, сделай другой нейминг какой именно image
aitemr
reviewed
Mar 19, 2023
| } | ||
|
|
||
| override func prepareForReuse() { | ||
| self.image.image = nil |
There was a problem hiding this comment.
self.image.image плохое обращения, лучше подумай как можно сделать перемениновать ui свойство
aitemr
reviewed
Mar 19, 2023
|
|
||
| import UIKit | ||
|
|
||
| class AlbumsViewController: UIViewController { |
aitemr
reviewed
Mar 19, 2023
|
|
||
| private let settingsDelegate = MediaCollectionViewCell() | ||
|
|
||
| private lazy var collectionView: UICollectionView = { |
aitemr
reviewed
Mar 19, 2023
| return collectionView | ||
| }() | ||
|
|
||
| override func viewDidLoad() { |
aitemr
reviewed
Mar 19, 2023
|
|
||
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
| setupController() |
There was a problem hiding this comment.
setupController -> setupNavigationController
aitemr
reviewed
Mar 19, 2023
| } | ||
|
|
||
| private func setupController() { | ||
| view.backgroundColor = .white |
There was a problem hiding this comment.
view.backgroundColor = .white должен быть в методе setupViews
aitemr
reviewed
Mar 19, 2023
| } | ||
| } | ||
|
|
||
| @objc func libraryNCleftButtonTapped() { } |
aitemr
reviewed
Mar 19, 2023
|
|
||
| @objc func libraryNCleftButtonTapped() { } | ||
|
|
||
| private func createLayout() -> UICollectionViewCompositionalLayout { |
aitemr
reviewed
Mar 19, 2023
| heightDimension: .absolute(44) | ||
| ) | ||
| let layoutGroup = NSCollectionLayoutGroup.horizontal(layoutSize: groupSize, subitems: [layoutItem]) | ||
| // layoutGroup.contentInsets = NSDirectionalEdgeInsets(top: 5, leading: 5, bottom: 5, trailing: 5) |
There was a problem hiding this comment.
dead code, нельзя замочиенный код отправять в гит, всегда перед отправкой проверяй свой код, нужно удалить
aitemr
reviewed
Mar 19, 2023
| } | ||
| } | ||
|
|
||
| extension AlbumsViewController: UICollectionViewDelegate, UICollectionViewDataSource, UICollectionViewDelegateFlowLayout { |
aitemr
reviewed
Mar 19, 2023
|
|
||
| extension AlbumsViewController: UICollectionViewDelegate, UICollectionViewDataSource, UICollectionViewDelegateFlowLayout { | ||
| func numberOfSections(in collectionView: UICollectionView) -> Int { | ||
| AlbumModel.modelsArray.count |
There was a problem hiding this comment.
лучше return писать явно, return AlbumModel.modelsArray.count
aitemr
reviewed
Mar 19, 2023
| } | ||
|
|
||
| func collectionView(_ collectionView: UICollectionView, numberOfItemsInSection section: Int) -> Int { | ||
| AlbumModel.modelsArray[section].count |
There was a problem hiding this comment.
лучше return писать явно, return AlbumModel.modelsArray[section].count
aitemr
reviewed
Mar 19, 2023
|
|
||
| import UIKit | ||
|
|
||
| class MediaCollectionViewCell: UICollectionViewCell { |
aitemr
reviewed
Mar 19, 2023
|
|
||
| static let identifier = "MediaCollectionViewCell" | ||
|
|
||
| lazy var image: UIImageView = { |
There was a problem hiding this comment.
public, лучше явно указовай acess модификаторы
aitemr
reviewed
Mar 19, 2023
|
|
||
| private func setupConstraints() { | ||
| image.snp.makeConstraints { | ||
| $0.centerY.equalTo(contentView) |
There was a problem hiding this comment.
$0.centerY.leading.equalTo(contentView)
aitemr
reviewed
Mar 19, 2023
| } | ||
|
|
||
| override func prepareForReuse() { | ||
| self.image.image = nil |
aitemr
reviewed
Mar 19, 2023
|
|
||
| import UIKit | ||
|
|
||
| class ForYouViewController: UIViewController { |
aitemr
reviewed
Mar 19, 2023
| navigationItem.leftBarButtonItem?.tintColor = .black | ||
| } | ||
|
|
||
| @objc func libraryNCleftButtonTapped() { } |
aitemr
reviewed
Mar 19, 2023
| super.viewDidLoad() | ||
| view.backgroundColor = .white | ||
| title = "For You" | ||
| navigationController?.navigationBar.prefersLargeTitles = true |
There was a problem hiding this comment.
нужно вынести в отдельные методы, во viewdidload не должно быть логики
aitemr
reviewed
Mar 19, 2023
| import UIKit | ||
| import SnapKit | ||
|
|
||
| class LibraryViewController: UIViewController { |
aitemr
reviewed
Mar 19, 2023
|
|
||
| class LibraryViewController: UIViewController { | ||
|
|
||
| private lazy var collectionView: UICollectionView = { |
aitemr
reviewed
Mar 19, 2023
| return collectionView | ||
| }() | ||
|
|
||
| override func viewDidLoad() { |
aitemr
reviewed
Mar 19, 2023
| setupConstraints() | ||
| } | ||
|
|
||
| private func setupController() { |
aitemr
reviewed
Mar 19, 2023
|
|
||
| private func setupConstraints() { | ||
| collectionView.snp.makeConstraints { | ||
| $0.left.top.right.bottom.equalToSuperview() |
aitemr
reviewed
Mar 19, 2023
| } | ||
| } | ||
|
|
||
| @objc func libraryNCleftButtonTapped() { } |
aitemr
reviewed
Mar 19, 2023
|
|
||
| import UIKit | ||
|
|
||
| class SearchViewController: UIViewController { |
aitemr
reviewed
Mar 19, 2023
|
|
||
| class SearchViewController: UIViewController { | ||
|
|
||
| override func viewDidLoad() { |
aitemr
reviewed
Mar 19, 2023
| super.viewDidLoad() | ||
| view.backgroundColor = .white | ||
| title = "Search" | ||
| navigationController?.navigationBar.prefersLargeTitles = true |
aitemr
reviewed
Mar 19, 2023
| navigationItem.leftBarButtonItem?.tintColor = .black | ||
| } | ||
|
|
||
| @objc func libraryNCleftButtonTapped() { } |
aitemr
reviewed
Mar 19, 2023
|
|
||
| import UIKit | ||
|
|
||
| class TabBarController: UITabBarController { |
aitemr
reviewed
Mar 19, 2023
|
|
||
| class TabBarController: UITabBarController { | ||
|
|
||
| override func viewDidLoad() { |
aitemr
reviewed
Mar 19, 2023
| } | ||
|
|
||
| func setupTabBarViewControllers() { | ||
| let libraryVC = LibraryViewController() |
There was a problem hiding this comment.
не сокращай, libraryVC VC плохой нейминг, пиши полностью viewcontroller
aitemr
reviewed
Mar 19, 2023
| let searchIcon = UITabBarItem(title: "Search", image: UIImage(systemName: "magnifyingglass"), selectedImage: UIImage(systemName: "magnifyingglass")) | ||
| searchVC.tabBarItem = searchIcon | ||
|
|
||
| let libraryNC = UINavigationController(rootViewController: libraryVC) |
aitemr
reviewed
Mar 19, 2023
| } | ||
|
|
||
| func collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) -> UICollectionViewCell { | ||
| let item = collectionView.dequeueReusableCell(withReuseIdentifier: "cell", for: indexPath) |
There was a problem hiding this comment.
cell Identifier лучше вынести во. static
aitemr
reviewed
Mar 19, 2023
| let layoutGroup = NSCollectionLayoutGroup.horizontal(layoutSize: groupSize, subitems: [layoutItem]) | ||
| // layoutGroup.contentInsets = NSDirectionalEdgeInsets(top: 5, leading: 5, bottom: 5, trailing: 5) | ||
| let layoutSection = NSCollectionLayoutSection(group: layoutGroup) | ||
| // layoutSection.orthogonalScrollingBehavior = .continuous |
aitemr
reviewed
Mar 19, 2023
|
|
||
| import UIKit | ||
|
|
||
| struct AlbumModel { |
There was a problem hiding this comment.
лучше пиши Album, models нагружает читабельность
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finished adding features, ready merge to main