[pending verification] fix(downloadMedia): simplify and add RMR recovery for NEED_POKE#85
Open
Adi1231234 wants to merge 1 commit intomain-with-fixesfrom
Open
Conversation
Adi1231234
force-pushed
the
fix/media-download-rmr-main-with-fixes
branch
2 times, most recently
from
d8e6bd7 to
fad4e27
Compare
Adi1231234
changed the title
wrap msg.downloadMedia() in try-catch since it can throw during resolution. Add NEED_POKE recovery that marks the download entry as off-server to force RMR retry. Expand failure conditions to include NEED_POKE and REUPLOADING stages, and throw an error instead of returning null so callers get a clear failure signal.
Adi1231234
force-pushed
the
fix/media-download-rmr-main-with-fixes
branch
from
fad4e27 to
693965d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same as PR #84 (for main-with-fixes-and-logs) but without diagnostic logging.
msg.downloadMedia()handle resolve (entries, RMR on 404, download, decrypt, LRU cache)downloadAndMaybeDecryptcache hit after resolveTest plan