fix: sync missing changes from upstream PRs #201660 and #127083#79
Closed
Adi1231234 wants to merge 1 commit intomain-with-fixes-and-logsfrom
Closed
fix: sync missing changes from upstream PRs #201660 and #127083#79Adi1231234 wants to merge 1 commit intomain-with-fixes-and-logsfrom
Adi1231234 wants to merge 1 commit intomain-with-fixes-and-logsfrom
Conversation
…127083 - RemoteAuth: pass session name directly to store.save instead of full path (fixes PR wwebjs#201660 - path.join was passing the full filesystem path instead of just the session identifier) - Client: register framenavigated listener before calling inject() so any page navigation that occurs during initialization is captured (fixes PR wwebjs#127083 ordering issue)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs two fixes from
main-with-fixesthat were missing inmain-with-fixes-and-logs:RemoteAuth:
store.save()was receivingpath.join(this.dataPath, this.sessionName)(full filesystem path) instead of justthis.sessionName(session identifier). This caused the remote store to save with the wrong key. (upstream PR fix(RemoteAuth): pass session name to store.save instead of full path wwebjs/whatsapp-web.js#201660)Client:
await this.inject()was called before registering theframenavigatedlistener, so any page navigation during initialization was not captured. Movedinject()after listener registration. (upstream PR fix: make inject() resilient to page navigation during initialization wwebjs/whatsapp-web.js#127083)Test plan
inject()are captured by theframenavigatedlistener