fix: make inject() resilient to page navigation during initialization#22
Closed
Adi1231234 wants to merge 1 commit intocombined-fixesfrom
Closed
fix: make inject() resilient to page navigation during initialization#22Adi1231234 wants to merge 1 commit intocombined-fixesfrom
Adi1231234 wants to merge 1 commit intocombined-fixesfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inject()usespage.evaluate()in polling loops to wait forwindow.Debug?.VERSIONandwindow.Store. After sleep/resume, Chrome may perform an internal page navigation (IndexedDB recovery) that destroys the execution context, causingpage.evaluate()to throw.This PR:
page.evaluate()polling loops withpage.waitForFunction(), which natively survives execution context destructionframenavigatedlistener registration to beforeinject()ininitialize()Also submitted upstream: wwebjs#127083