fix: make inject() resilient to page navigation during initialization#21
Closed
Adi1231234 wants to merge 11 commits intocombined-fixesfrom
Closed
fix: make inject() resilient to page navigation during initialization#21Adi1231234 wants to merge 11 commits intocombined-fixesfrom
Adi1231234 wants to merge 11 commits intocombined-fixesfrom
Conversation
* New property isLocked * New property isLocked
Co-authored-by: BenyFilho <168232825+BenyFilho@users.noreply.github.com> Co-authored-by: tuyuribr <45042245+tuyuribr@users.noreply.github.com>
Replace manual evaluate-based polling loops with waitForFunction, which natively survives execution context destruction caused by page navigation (e.g. Chrome's internal IndexedDB recovery after system sleep/resume). Also move the framenavigated listener registration before the initial inject() call, so navigation events during inject are handled by the existing listener. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inject()usespage.evaluate()in polling loops to wait forwindow.Debug?.VERSIONandwindow.Store. After sleep/resume, Chrome may perform an internal page navigation (IndexedDB recovery) that destroys the execution context, causingpage.evaluate()to throw.This PR:
page.evaluate()polling loops withpage.waitForFunction(), which natively survives execution context destructionframenavigatedlistener registration to beforeinject()ininitialize()Also submitted upstream: wwebjs#127083
Test plan
🤖 Generated with Claude Code