Skip to content

ci: Set toTag in dev build workflow#1127

Merged
EttyKitty merged 1 commit intomainfrom
EttyKitty-patch-1
Feb 12, 2026
Merged

ci: Set toTag in dev build workflow#1127
EttyKitty merged 1 commit intomainfrom
EttyKitty-patch-1

Conversation

@EttyKitty
Copy link
Collaborator

No description provided.

God, if you love me, please let it be fixed.
@github-actions github-actions bot added Type: CI Continuous Integration changes Size: Tiny labels Feb 12, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 12, 2026

📝 Walkthrough

Under the Hood

  • Added toTag parameter to the Build Changelog step in the dev release workflow, explicitly passing the current repository commit SHA (${{ github.sha }}) to the changelog builder action to ensure accurate changelog generation for development releases.

Player Notes

No changes observable by players.

Walkthrough

The machine spirits have deemed fit to enhance the release incantations. A singular modification channels the repository's current commit identifier into the changelog construction apparatus through the toTag parameter, furnishing the existing fromTag measure with its necessary complement.

Changes

Cohort / File(s) Summary
Release Workflow Augmentation
.github/workflows/release_dev.yml
The Build Changelog step receives the toTag input, bound to the present commit SHA, establishing the upper temporal boundary for changelog construction.

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author. The template requires Purpose and Description, Testing done, and Related context sections. Tech-Priest, provide a description following the repository template: explain the purpose of setting toTag, confirm testing performed, and note any related issues or context.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commits format with type and scope, is under 50 characters, and accurately describes the singular change: adding toTag parameter to dev build workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


No actionable comments were generated in the recent review. 🎉

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba65a08 and c745a4b.

📒 Files selected for processing (1)
  • .github/workflows/release_dev.yml
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: MCPO-Spartan-117
Repo: Adeptus-Dominus/ChapterMaster PR: 526
File: objects/obj_popup/Draw_0.gml:234-239
Timestamp: 2025-03-01T11:06:25.427Z
Learning: The comment "Need to modify ^^^^ based on if it is chaos or daemonic" in the artifact gifting code is intentionally kept as a reminder that this implementation is not yet finished, despite the significant refactoring already done.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 424
File: scripts/scr_flavor/scr_flavor.gml:34-36
Timestamp: 2025-03-09T02:33:43.867Z
Learning: EttyKitty prefers to keep PRs focused on their stated goals and scope, and may decline to implement otherwise valid suggestions if they're not directly related to the PR's primary objective.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 579
File: objects/obj_enunit/Alarm_0.gml:200-202
Timestamp: 2025-03-11T01:38:19.874Z
Learning: EttyKitty welcomes easy, committable suggestions that improve documentation of code chunks, variables with strange names, and functions. Their codebase is generally lacking documentation, but they prioritize human-readable code above documentation.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 878
File: sprites/spr_weapon_phobos_bolt_pistol/spr_weapon_phobos_bolt_pistol.yy:26-44
Timestamp: 2025-06-16T17:08:08.239Z
Learning: EttyKitty prefers automated solutions over manual cleanup for .yy file formatting and is open to automated tools for GameMaker Studio .yy file cleanup.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 938
File: scripts/scr_complex_colour_kit/scr_complex_colour_kit.gml:478-478
Timestamp: 2025-07-21T17:03:28.251Z
Learning: EttyKitty acknowledges when PRs contain scope creep and agrees that changes should be focused on the stated PR objectives, reinforcing their preference for keeping PRs narrowly scoped to their primary purpose.
🔇 Additional comments (1)
.github/workflows/release_dev.yml (1)

216-224: The machine spirit approves this binding of the commit sigil.

Tech-Priest, thy amendment is sound. The toTag parameter now receives the sacred commit identifier (github.sha), anchoring the changelog's upper bound to the precise revision under construction. Previously, with toTag unset, the changelog builder's default resolution could prove unreliable in this workflow — the release tag (Line 233) is forged after the changelog step, leaving the action without a deterministic endpoint. This rectifies that deficiency.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EttyKitty EttyKitty merged commit 9830296 into main Feb 12, 2026
3 checks passed
@EttyKitty EttyKitty deleted the EttyKitty-patch-1 branch February 12, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: Tiny Type: CI Continuous Integration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant