fix: General Code Refactoring#1081

Closed

carys-the-weed-cloud wants to merge 46 commits intoAdeptus-Dominus:mainfrom

carys-the-weed-cloud:carys-bug-fixes

Commits on Dec 26, 2025

Cleared GM1017 suggestions, deprecated functions are replaced with maintained versions, and whitespace in touched files normalized.
carys-the-weed-cloud
committed

Commits on Dec 27, 2025

scr_Table whitespace cleanup
carys-the-weed-cloud
committed
GM1020 error cleanup, function call does nothing but throw an error.
carys-the-weed-cloud
committed
Cleared GM1007 Error, local variable Space Marine luck stat was being overriden by the global luck enum. luck enum renamed to eLUCK, matching CODE_STYLE.md suggestion. Space Marine Luck stat potent…
carys-the-weed-cloud
committed
I have discovered the linter and have used it appropriately. Woops.
carys-the-weed-cloud
committed
Silence GM1021 Error in scr_buttons by initializing bind_method as an empty function instead of a string.
carys-the-weed-cloud
committed
linted scr_buttons
carys-the-weed-cloud
committed
Silence other GM1021 Errors
carys-the-weed-cloud
committed
linted scr_controller
carys-the-weed-cloud
committed
Silenced GM2047 suggestions about unreachable code by commenting them out for review of if they are meant to be reachable before the return statement, or if they can simply be deleted. Though the o…
carys-the-weed-cloud
committed
linted scr_DataSlate and scr_culture_visuals
carys-the-weed-cloud
committed
Resolve deprecated draw_line camera calls for objects to silence some GM1024 warnings
carys-the-weed-cloud
committed
Make the rabbit happy.
carys-the-weed-cloud
committed
Lint obj_controller
carys-the-weed-cloud
committed
Add back in the update() function to the Table but in the correct place.
carys-the-weed-cloud
committed
Small correction for overzealous linter.
carys-the-weed-cloud
committed
Correctly set framerate with fleet objects.
carys-the-weed-cloud
committed
We are converting these Real's to bools for the sake of math, so we might as well make that clearer via using the bool() function instead of 'git add objects/obj_fleet/Draw_64.gml' (which the ettyb…
carys-the-weed-cloud
committed
Linted obj_fleet
carys-the-weed-cloud
committed
Merge branch 'Adeptus-Dominus:main' into carys-bug-fixes
carys-the-weed-cloud
authored
ChapterMaster.yyp wants to auto change this line everytime i open the project and I don't see anything wrong with it?
carys-the-weed-cloud
committed
linted scr_draw_unit_stat_data.gml
carys-the-weed-cloud
committed
refactored GENDER enum to eGENDER according to COD_STYLE.md
carys-the-weed-cloud
committed
Refactored MENU enum to eMENU according to CODE_STYLE.md
carys-the-weed-cloud
committed
enum GOD_MISSION seems to be unused for now but has now been refactored to be eGOD_MISSION according to CODE_STYLE.md
carys-the-weed-cloud
committed
Refactored INQUISITION_MISSION to eINQUISITION_MISSION according to CODE_STYLE.md
carys-the-weed-cloud
committed
Refactored EVENT enum to eEVENT according to CODE_STYLE.md
carys-the-weed-cloud
committed
Linted all files touched by the macro enum refractor. This probably cleared out a slew of minor logic bugs just sitting in the code.
carys-the-weed-cloud
committed
Quick review of changes i've already made.
carys-the-weed-cloud
committed
Huh the linter broke there for some reason that I can't figure out.
carys-the-weed-cloud
committed
I lied it was glaringly obvious don't mix your struct string literals with an array of strings!
carys-the-weed-cloud
committed
Shush a silly compiler warning about type mismatches against what the jsdoc is saying. The jsdoc in this case was wrong based on the operation of role_groups().
carys-the-weed-cloud
committed
Don't name things too generic or else the loose typing of the language will get confused on if you are using a local var or a generic core library function.
carys-the-weed-cloud
committed

Commits on Dec 28, 2025