feat: Most of Tartaros shadow packets

[OH296]

Purpose and Description

• Self-descriptive.

Testing done

• None, and I understand the risks.

Related things and/or additional context

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Summary by CodeRabbit

• New Features

  • Expanded Tartaros armour visuals with new components (forehead, gorget, head, right arm/leg) including shadows, variants, and leg rivet details.
  • Enhanced modular rendering with new drawable items, flips, shadows, and subcomponents for Tartaros pieces.
  • Updated sprite sequences and dimensions for smoother display.

• Changes

  • Adjusted default Tartaros component assignments, which may subtly alter the visual composition of that armour set.

Walkthrough

Tech-Priest, new Tartaros sprite assets are registered, several existing sprite sequences are adjusted, and modular drawing entries are expanded. The Tartaros group in scr_ComplexSet prunes component assignments. ChapterMaster.yyp gains new resources; scr_culture_visuals adds drawing items for right arm, gorget, head, forehead, and right leg.

Changes

Cohort / File(s)	Change summary
Project resource registry ChapterMaster.yyp	Appends new Tartaros sprite resources (forehead/ gorget/ head/ right arm/ right leg shadows; forehead variants; leg rivets).
Armour construction logic scripts/scr_ComplexSet/scr_ComplexSet.gml	In Tartaros add_group, removes fields: left_arm, right_arm, right_leg, left_leg, gorget, head; retains chest_variants, mouth_variants, trims.
Modular drawing registration scripts/scr_culture_visuals/scr_culture_visuals.gml	Adds modular items for Tartaros: right_arm (flip, shadows), gorget (shadows), head (shadows), forhead/forehead (shadows), right_leg (flip, shadows, rivets subcomponent).
New sprites (Tartaros shadows/rivets) sprites/spr_tartaros_forehead_shadows/spr_tartaros_forehead_shadows.yy, sprites/spr_tartaros_forehead_variants/spr_tartaros_forehead_variants.yy, sprites/spr_tartaros_gorget_shadows/spr_tartaros_gorget_shadows.yy, sprites/spr_tartaros_head_shadows/spr_tartaros_head_shadows.yy, sprites/spr_tartaros_leg_rivets/spr_tartaros_leg_rivets.yy, sprites/spr_tartaros_right_arm_shadows/spr_tartaros_right_arm_shadows.yy, sprites/spr_tartaros_right_leg_shadows/spr_tartaros_right_leg_shadows.yy	Adds new GMSprite assets with frames, layers, sequences; static data only.
Sprite sequence/metadata updates sprites/spr_tartaros_gorget/spr_tartaros_gorget.yy, sprites/spr_tartaros_head_variants/spr_tartaros_head_variants.yy, sprites/spr_tartaros_right_arm/spr_tartaros_right_arm.yy, sprites/spr_tartaros_right_leg/spr_tartaros_right_leg.yy	Adds seqWidth/seqHeight metadata; restructures keyframes; reduces frames in head_variants and right_leg; updates sequence lengths accordingly.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• feat: Tartaros armour main body shadows #1032 — Touches Tartaros assets and the same scripts (scr_ComplexSet, scr_culture_visuals) for armour component handling.
• feat: flip functionality and arm shadows #1021 — Adjusts right-arm entries and modular drawing items in the same areas affected here.
• feat: Responsive marine colour selector #539 — Registers new armour sprites in ChapterMaster.yyp and modular drawing, paralleling these changes.

Suggested labels

PR: Feature, PR: Sprites, Area: Sprites, Size: Huge

Suggested reviewers

• EttyKitty

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	Tech-Priest, the pull request description merely repeats the template headings and contains placeholder text without any actual overview of the changes, making it overly generic and incomplete.	Populate the “Purpose and Description” section with a clear summary of the additions and removals (e.g., new Tartaros shadow sprites and script adjustments), detail any testing performed, and provide relevant context or links in the related-context section.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	Tech-Priest, the title follows the conventional commit format with type “feat” and a concise summary under fifty characters, matching the required `<type>(<scope>): <Short summary>` pattern.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

sprites/spr_tartaros_head_variants/spr_tartaros_head_variants.yy (1)

14-16: Restore missing head-variant frames, Tech-Priest.

Machine-spirit diagnostics detect that spr_tartaros_head_variants now exposes only a lone frame and keyframe. Prior data housed multiple heads for modular selection; with only one, any lookup of higher indices collapses to the same visage, stripping variant diversity and desynchronising with configuration tables that still enumerate the previous set. Reinstating the full frame array and matching keyframes is required before communion with mainline.

Also applies to: 72-76

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 870ef65 and 438a6ef.

⛔ Files ignored due to path filters (46)

• sprites/spr_tartaros_forehead_shadows/40bc99d5-36c6-494f-ac41-97db7b1af50a.png is excluded by !**/*.png
• sprites/spr_tartaros_forehead_shadows/9d5b17e4-eb9a-46c2-a4a7-6dbbfac5dfe3.png is excluded by !**/*.png
• sprites/spr_tartaros_forehead_shadows/b529fb18-f4ec-47d1-b6b3-ed4a9f174496.png is excluded by !**/*.png
• sprites/spr_tartaros_forehead_shadows/fd6650e0-331d-4ca5-8853-0b5406c4134d.png is excluded by !**/*.png
• sprites/spr_tartaros_forehead_shadows/layers/40bc99d5-36c6-494f-ac41-97db7b1af50a/3156c4a2-0553-4e28-b1dd-29e32750bb31.png is excluded by !**/*.png
• sprites/spr_tartaros_forehead_shadows/layers/9d5b17e4-eb9a-46c2-a4a7-6dbbfac5dfe3/3156c4a2-0553-4e28-b1dd-29e32750bb31.png is excluded by !**/*.png
• sprites/spr_tartaros_forehead_shadows/layers/b529fb18-f4ec-47d1-b6b3-ed4a9f174496/3156c4a2-0553-4e28-b1dd-29e32750bb31.png is excluded by !**/*.png
• sprites/spr_tartaros_forehead_shadows/layers/fd6650e0-331d-4ca5-8853-0b5406c4134d/3156c4a2-0553-4e28-b1dd-29e32750bb31.png is excluded by !**/*.png
• sprites/spr_tartaros_forehead_variants/40bc99d5-36c6-494f-ac41-97db7b1af50a.png is excluded by !**/*.png
• sprites/spr_tartaros_forehead_variants/9d5b17e4-eb9a-46c2-a4a7-6dbbfac5dfe3.png is excluded by !**/*.png
• sprites/spr_tartaros_forehead_variants/b529fb18-f4ec-47d1-b6b3-ed4a9f174496.png is excluded by !**/*.png
• sprites/spr_tartaros_forehead_variants/fd6650e0-331d-4ca5-8853-0b5406c4134d.png is excluded by !**/*.png
• sprites/spr_tartaros_forehead_variants/layers/40bc99d5-36c6-494f-ac41-97db7b1af50a/3156c4a2-0553-4e28-b1dd-29e32750bb31.png is excluded by !**/*.png
• sprites/spr_tartaros_forehead_variants/layers/9d5b17e4-eb9a-46c2-a4a7-6dbbfac5dfe3/3156c4a2-0553-4e28-b1dd-29e32750bb31.png is excluded by !**/*.png
• sprites/spr_tartaros_forehead_variants/layers/b529fb18-f4ec-47d1-b6b3-ed4a9f174496/3156c4a2-0553-4e28-b1dd-29e32750bb31.png is excluded by !**/*.png
• sprites/spr_tartaros_forehead_variants/layers/fd6650e0-331d-4ca5-8853-0b5406c4134d/3156c4a2-0553-4e28-b1dd-29e32750bb31.png is excluded by !**/*.png
• sprites/spr_tartaros_gorget_shadows/7183111f-9020-46b1-8c8d-6f3863650227.png is excluded by !**/*.png
• sprites/spr_tartaros_gorget_shadows/7f9b6976-da75-43c8-97e3-acfa8912ef0e.png is excluded by !**/*.png
• sprites/spr_tartaros_gorget_shadows/8d99f92f-4aac-47e4-a142-c6ea6be47856.png is excluded by !**/*.png
• sprites/spr_tartaros_gorget_shadows/ead692b6-35d8-4ebb-bc75-76c2fbfae9ef.png is excluded by !**/*.png
• sprites/spr_tartaros_gorget_shadows/layers/7183111f-9020-46b1-8c8d-6f3863650227/50a6880d-f9bf-4734-a44b-81b675bc6761.png is excluded by !**/*.png
• sprites/spr_tartaros_gorget_shadows/layers/7f9b6976-da75-43c8-97e3-acfa8912ef0e/50a6880d-f9bf-4734-a44b-81b675bc6761.png is excluded by !**/*.png
• sprites/spr_tartaros_gorget_shadows/layers/8d99f92f-4aac-47e4-a142-c6ea6be47856/50a6880d-f9bf-4734-a44b-81b675bc6761.png is excluded by !**/*.png
• sprites/spr_tartaros_gorget_shadows/layers/ead692b6-35d8-4ebb-bc75-76c2fbfae9ef/50a6880d-f9bf-4734-a44b-81b675bc6761.png is excluded by !**/*.png
• sprites/spr_tartaros_head_shadows/fd6650e0-331d-4ca5-8853-0b5406c4134d.png is excluded by !**/*.png
• sprites/spr_tartaros_head_shadows/layers/fd6650e0-331d-4ca5-8853-0b5406c4134d/3156c4a2-0553-4e28-b1dd-29e32750bb31.png is excluded by !**/*.png
• sprites/spr_tartaros_head_variants/40bc99d5-36c6-494f-ac41-97db7b1af50a.png is excluded by !**/*.png
• sprites/spr_tartaros_head_variants/9d5b17e4-eb9a-46c2-a4a7-6dbbfac5dfe3.png is excluded by !**/*.png
• sprites/spr_tartaros_head_variants/b529fb18-f4ec-47d1-b6b3-ed4a9f174496.png is excluded by !**/*.png
• sprites/spr_tartaros_head_variants/layers/40bc99d5-36c6-494f-ac41-97db7b1af50a/3156c4a2-0553-4e28-b1dd-29e32750bb31.png is excluded by !**/*.png
• sprites/spr_tartaros_head_variants/layers/9d5b17e4-eb9a-46c2-a4a7-6dbbfac5dfe3/3156c4a2-0553-4e28-b1dd-29e32750bb31.png is excluded by !**/*.png
• sprites/spr_tartaros_head_variants/layers/b529fb18-f4ec-47d1-b6b3-ed4a9f174496/3156c4a2-0553-4e28-b1dd-29e32750bb31.png is excluded by !**/*.png
• sprites/spr_tartaros_leg_rivets/b53b7c9e-26af-4c4b-9b89-a15af4f7296c.png is excluded by !**/*.png
• sprites/spr_tartaros_leg_rivets/layers/b53b7c9e-26af-4c4b-9b89-a15af4f7296c/b1ad68ac-732f-42d2-971e-e7f6a4962e33.png is excluded by !**/*.png
• sprites/spr_tartaros_right_arm_shadows/87c9365b-ef0b-48e1-a764-b2b2b8937c67.png is excluded by !**/*.png
• sprites/spr_tartaros_right_arm_shadows/layers/87c9365b-ef0b-48e1-a764-b2b2b8937c67/c87e73e1-e866-4b39-8a1f-96167acb2eca.png is excluded by !**/*.png
• sprites/spr_tartaros_right_leg/b53b7c9e-26af-4c4b-9b89-a15af4f7296c.png is excluded by !**/*.png
• sprites/spr_tartaros_right_leg/layers/b53b7c9e-26af-4c4b-9b89-a15af4f7296c/b1ad68ac-732f-42d2-971e-e7f6a4962e33.png is excluded by !**/*.png
• sprites/spr_tartaros_right_leg_shadows/8d99f92f-4aac-47e4-a142-c6ea6be47856.png is excluded by !**/*.png
• sprites/spr_tartaros_right_leg_shadows/efcff506-8258-4e7c-89aa-82cc9816fb9f.png is excluded by !**/*.png
• sprites/spr_tartaros_right_leg_shadows/f31258fb-8e42-40fa-9abe-d50ce4077249.png is excluded by !**/*.png
• sprites/spr_tartaros_right_leg_shadows/fa086401-4b32-4bee-a3f9-fb5ec4f5bfa2.png is excluded by !**/*.png
• sprites/spr_tartaros_right_leg_shadows/layers/8d99f92f-4aac-47e4-a142-c6ea6be47856/b1ad68ac-732f-42d2-971e-e7f6a4962e33.png is excluded by !**/*.png
• sprites/spr_tartaros_right_leg_shadows/layers/efcff506-8258-4e7c-89aa-82cc9816fb9f/b1ad68ac-732f-42d2-971e-e7f6a4962e33.png is excluded by !**/*.png
• sprites/spr_tartaros_right_leg_shadows/layers/f31258fb-8e42-40fa-9abe-d50ce4077249/b1ad68ac-732f-42d2-971e-e7f6a4962e33.png is excluded by !**/*.png
• sprites/spr_tartaros_right_leg_shadows/layers/fa086401-4b32-4bee-a3f9-fb5ec4f5bfa2/b1ad68ac-732f-42d2-971e-e7f6a4962e33.png is excluded by !**/*.png

📒 Files selected for processing (14)

• ChapterMaster.yyp (1 hunks)
• scripts/scr_ComplexSet/scr_ComplexSet.gml (0 hunks)
• scripts/scr_culture_visuals/scr_culture_visuals.gml (2 hunks)
• sprites/spr_tartaros_forehead_shadows/spr_tartaros_forehead_shadows.yy (1 hunks)
• sprites/spr_tartaros_forehead_variants/spr_tartaros_forehead_variants.yy (1 hunks)
• sprites/spr_tartaros_gorget/spr_tartaros_gorget.yy (1 hunks)
• sprites/spr_tartaros_gorget_shadows/spr_tartaros_gorget_shadows.yy (1 hunks)
• sprites/spr_tartaros_head_shadows/spr_tartaros_head_shadows.yy (1 hunks)
• sprites/spr_tartaros_head_variants/spr_tartaros_head_variants.yy (2 hunks)
• sprites/spr_tartaros_leg_rivets/spr_tartaros_leg_rivets.yy (1 hunks)
• sprites/spr_tartaros_right_arm/spr_tartaros_right_arm.yy (1 hunks)
• sprites/spr_tartaros_right_arm_shadows/spr_tartaros_right_arm_shadows.yy (1 hunks)
• sprites/spr_tartaros_right_leg/spr_tartaros_right_leg.yy (2 hunks)
• sprites/spr_tartaros_right_leg_shadows/spr_tartaros_right_leg_shadows.yy (1 hunks)

💤 Files with no reviewable changes (1)

• scripts/scr_ComplexSet/scr_ComplexSet.gml

🧰 Additional context used

📓 Path-based instructions (3)

**/*.*

⚙️ CodeRabbit configuration file

**/*.*: - Having humanly understandable and maintainable code is the top most priority.

• DRY (Don't repeat yourself) principle is also very important.
• If a TODO comment is added, ask the user if you should create a GitHub issue for this TODO.
• If a TODO comment is deleted, remind the user if there is an active GitHub issue related to that comment.

Files:

• sprites/spr_tartaros_right_arm/spr_tartaros_right_arm.yy
• sprites/spr_tartaros_gorget/spr_tartaros_gorget.yy
• sprites/spr_tartaros_right_leg_shadows/spr_tartaros_right_leg_shadows.yy
• sprites/spr_tartaros_forehead_variants/spr_tartaros_forehead_variants.yy
• sprites/spr_tartaros_forehead_shadows/spr_tartaros_forehead_shadows.yy
• sprites/spr_tartaros_head_shadows/spr_tartaros_head_shadows.yy
• sprites/spr_tartaros_right_leg/spr_tartaros_right_leg.yy
• scripts/scr_culture_visuals/scr_culture_visuals.gml
• sprites/spr_tartaros_right_arm_shadows/spr_tartaros_right_arm_shadows.yy
• ChapterMaster.yyp
• sprites/spr_tartaros_head_variants/spr_tartaros_head_variants.yy
• sprites/spr_tartaros_leg_rivets/spr_tartaros_leg_rivets.yy
• sprites/spr_tartaros_gorget_shadows/spr_tartaros_gorget_shadows.yy

**/*.yy

⚙️ CodeRabbit configuration file

**/*.yy: - When any script or sprite .yy files are deleted, their paths should also be deleted from the project .yyp file, otherwise the game will crash.

• When any script or sprite .yy files are created, their paths should be added to the project .yyp file, otherwise they'll fail.

Files:

• sprites/spr_tartaros_right_arm/spr_tartaros_right_arm.yy
• sprites/spr_tartaros_gorget/spr_tartaros_gorget.yy
• sprites/spr_tartaros_right_leg_shadows/spr_tartaros_right_leg_shadows.yy
• sprites/spr_tartaros_forehead_variants/spr_tartaros_forehead_variants.yy
• sprites/spr_tartaros_forehead_shadows/spr_tartaros_forehead_shadows.yy
• sprites/spr_tartaros_head_shadows/spr_tartaros_head_shadows.yy
• sprites/spr_tartaros_right_leg/spr_tartaros_right_leg.yy
• sprites/spr_tartaros_right_arm_shadows/spr_tartaros_right_arm_shadows.yy
• sprites/spr_tartaros_head_variants/spr_tartaros_head_variants.yy
• sprites/spr_tartaros_leg_rivets/spr_tartaros_leg_rivets.yy
• sprites/spr_tartaros_gorget_shadows/spr_tartaros_gorget_shadows.yy

**/*.gml

⚙️ CodeRabbit configuration file

**/*.gml: - Macro constants require a space between the constant name and value. Without it, the compiler will throw an error. I.e. #macro ARR_body_parts["arm"] will crash the game, because there is no space between the array and the name of the macro.

• Color codes in the code shouldn't have any spaces in their id. I.e., color code # 80bf40 will crash the game.
• All code should comply with the main GML documentation: https://manual.gamemaker.io/beta/en/GameMaker_Language/GML_Reference/GML_Reference.htm

Files:

• scripts/scr_culture_visuals/scr_culture_visuals.gml

🔇 Additional comments (8)

sprites/spr_tartaros_leg_rivets/spr_tartaros_leg_rivets.yy (1)

1-92: Sprite manifest aligned

Tech-Priest, the rivet sprite manifest aligns with MarineViewer standards; bounds and origin are harmonious with the right leg lattice. No further rites required.

sprites/spr_tartaros_forehead_shadows/spr_tartaros_forehead_shadows.yy (1)

1-104: Shadow sequence sanctified

Tech-Priest, the forehead shadow sequence is orderly; frame cadence and origin sit precisely within Tartaros expectations.

ChapterMaster.yyp (1)

1643-1655: Registry augmentation complete

Tech-Priest, the newly forged tartaros resources are duly inscribed within the project litany, preventing load-time voids.

sprites/spr_tartaros_right_leg_shadows/spr_tartaros_right_leg_shadows.yy (1)

1-104: Right-leg shadow schema true

Tech-Priest, this shadow schema aligns with the leg articulation; frame phasing and collision wards are immaculate.

scripts/scr_culture_visuals/scr_culture_visuals.gml (4)

1439-1446: LGTM: Right arm entry for Tartaros armour is properly forged.

The structure aligns with established patterns, Tech-Priest. Sprites, shadows, and flip designation are correctly registered.

---

1447-1453: LGTM: Gorget entry is sanctioned.

This component adheres to sacred protocols, Tech-Priest. Sprite and shadow registrations are properly aligned.

---

1454-1460: LGTM: Head variants entry is correctly inscribed.

The head component for Tartaros armour follows the ordained pattern, Tech-Priest. Shadow sprites are properly bound.

---

1468-1478: LGTM: Right leg entry with subcomponents is properly configured.

The right leg component for Tartaros armour is correctly structured, Tech-Priest. The subcomponents array includes rivet sprites as intended, and the flip designation is appropriately set.