Removed RegressionBase in Lightning Modules #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Lightning modules to remove the RegressionBase inheritance.
The RegressionBase class had become a “bloated” base, mixing concerns that were not shared by all Lightning modules.
Each Lightning module that previously depended on RegressionBase is now a standalone LightningModule with its own clearly defined hooks (training/validation/test/predict, logging, etc.).
Shared utilities are kept as small helper functions instead of an implicit base class dependency.
This makes the modules easier to read, extend, and test in isolation, and reduces the coupling between future changes in regression logic and the Lightning modules themselves.