Fix to Bayesian Network Predict Call and Individual Preds #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@Samuel-WM Just updated git workflows to run CI tests for fork PRs. Please pull main into this branch to run. |
Collaborator
|
Code changes LGTM, feel free to merge once tests are run successfully in github actions. You should have permissions @Samuel-WM |
…True to False in the method signature of predict_precisions and predict_correlation
Samuel-WM
force-pushed
the
fix/individual_preds
branch
from
3ccfb0a to
1e3a847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix issues #173 and #266. The main problem was inconsistent defaults for individual_preds and broken predict behavior when using GraphTrainer. Method signatures were adjusted so individual_preds always defaults the same way. No more surprises depending on which method is called.
A new predict method was also added to ContextualizedBayesianNetworks. Before, predict fell back to the SKLearnWrapper, which doesn’t play nice with GraphTrainer and caused errors. Now predict works directly for Bayesian networks: it calls predict_networks to get betas, then uses _reconstruct_from_betas to rebuild the features.