Skip to content

Argument management cleanup and linear encoder bugfix #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cnellington wants to merge 23 commits into from
Closed

Argument management cleanup and linear encoder bugfix #267

cnellington wants to merge 23 commits into from

Conversation

@cnellington
Copy link
Collaborator

@cnellington cnellington commented Jul 31, 2025 •
edited
Loading

Adapted from #265 to fix tests and enable CI runner

  • Clean up kwarg management in easy and regression modules to fail quickly with incorrect arguments and avoid silent failures
  • Dissallow univariate kwarg from being configured, since changing this in easy or lightning_modules is breaking in almost every case.
  • Bugfix to enable linear encoder

Peter Li and others added 23 commits June 25, 2025 16:40
initial commit; solved issue #237
167f345
Refactor kwargs to clearly pass encoder_type='linear'; Refactoring SK…
c3eba70 
…LearnWrapper unsolved
Add type hints
59210d7
Retain some parameters for encoder
f47f12e
configure width, layers, or other metamodel args in _build_metamodel
9316b5d
Run format sh
915df88
Expanding encoder_kwargs in other metamodels
6225d48
_build_metamodel keep optional args in kwargs
3ee5fce
Add kwargs in Sklearn to allow special args for all metamodels
1fe9940
Expand for tasksplitmodel
b73136e
Expand init and _build for more class
9c48790
Add all needed args in base constructor
cdcc4be
Expanding init and _build_metamodel in lightning modules to all explicit
a24e323
Finish Expanding
467fa3c
restore base constructor in SKlearn to use kwargs, since subclass nee…
6762d15 
…ds different args
Expand encoder kwargs to width layer link_fn thoroughly in SKlearn
5f0ba2c
Keep width and layers (no encoder prefix); set both link_fn and encod…
62b44be 
…er_link_fn in Base init
Expand encoder kwargs in test_naive
f0b0de3
Restore kwargs in Base init for compatiblity
4fa3077
every class (except the four about correlation)in Lightning modules p…
4c1e686 
…assed args test - once there is unexpected arg, it will indicate error
small adjustment
333b996
Add unittest for lightning modules invalid params
307b92f
@cnellington
depreciate univariate arg entirely. Only used for internal configurat…
e99e87c 
…ion. Also format style
@cnellington
Copy link
Collaborator Author

cnellington commented Aug 6, 2025

Draft for #237

@cnellington cnellington closed this Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cnellington